Closed jfrux closed 6 years ago
I really wanted this to work. It looked so much easier and useful than the others I've seen. :-/
Okay it works when I clone it down and install it, but if I run it in my electron project I get that error. Wondering if its changing the context somehow.
I’ve run into a similar issue as well. @eviltik Perhaps the geo-ip module could be conditionally required only when passing the —geo flag?
@gabemarshall nice shot, let's do that
Cool, I can take a stab at it sometime within the week 👍
Does this tool work good, I've not had any luck with other scanning node apps because they never find things or are hit and miss so much so that I've just resorted to almost leaving scanning off all together.
Definitely had high hopes for this tool.
I'll probably have to end up forking and removing geo from it or finding a way to exclude it.
I'm sure someone else has a better grasp of what impact that would have.
@jfrux i don't know if this tool work good. But it should. If you find bad behavior, feel free to open a new ticket.
Ok, there is already a --geo option, but "require" don't take care if option has been specified or not. So, if geo option not specified, the module geoip-lite will not be loaded. Improving that right now.
I should clarify, I’m trying to use it inside of my node scripts (more specifically in Electron) versus from the CLI not sure if that’s relevant or not. On Sep 28, 2018, 12:46 PM -0400, eviltik notifications@github.com, wrote:
Ok, there is already a --geo option, but "require" don't take care if option has been specified or not. So, if geo option not specified, the module geoip-lite will not be loaded. Improving that right now. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.
options from inside a node script vs CLI are the same. geoip-lite module should not be loaded if you don't specify "geo" option
Hmm... I wasn’t using geo option but I’ll try it again soon. Thanks man! On Sep 28, 2018, 1:00 PM -0400, eviltik notifications@github.com, wrote:
options from inside a node script vs CLI are the same. geoip-lite module should not be loaded if you don't specify "geo" option. Default options for CLI vs inside a node scripts are the same. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.
done, pushing 1.7.1 into npm registry
1.7.1 available, please update and give feedback !
@jfrux you spoke about electron. I'm using nwjs on my side + webix (rather than qooxdoo) for the UI. Is it possible to have a screenshot when your app is ready ? thank you !
@eviltik Absolutely, in fact - here is the project: https://github.com/openpilot-community/workbench/
What's evilscan use case in your project in a few words ?
"Workbench uses evilscan for locating Comma.ai EON devices on your local network to help ease on-boarding for novice users." On Sep 28, 2018, 1:41 PM -0400, eviltik notifications@github.com, wrote:
What's evilscan use case in your project in a few words ? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.
ok, so do not hesitate to open tickets if you have any problem !
any feedback please ? ty
It’s working!
Get me the mac address from arp
and this would be 100%.
I love how I can filter out the responses I to just “open” by providing “O”
As far as general DX… not sure why you’re doing a string for the filter though, but I guess its okay!
That’s all I have for now I think…. Great work! On Oct 1, 2018, 12:32 PM -0400, eviltik notifications@github.com, wrote:
any feedback please ? ty — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.
What am I doing wrong? I installed it into my node project.