default state to cloaked

eviltrout / ember-cloaking

Support for not rendering offscreen views in an Ember app for performance

MIT License

294 stars 29 forks source link

default state to cloaked #15

Closed H1D closed 10 years ago

H1D commented 10 years ago

OK, let's start #12 over

This PR:

default state to cloaked
implemented defaultHeight (this must be implemented in order to have "cloaked" state as default)

go1dfish commented 10 years ago

I've tried this PR out and it works well for me and improves initial rendering time in my use case.

H1D commented 10 years ago

@eviltrout ping

eviltrout commented 10 years ago

Just tried it out and it works great. Thanks a lot!

gorner commented 10 years ago

One minor issue I've noticed with cloaking by default: If the cloaked-collection's content is being loaded asynchronously, the entire collection will be cloaked until a scroll event occurs because there's nothing to uncloak any view added to the collection after the scrollTriggered in _startEvents executes.

That said, I believe I have a fix and will submit a PR.

H1D commented 10 years ago

@gorner right! I forgot to add this method into my PR