search

eviltrout / ember-cloaking

Support for not rendering offscreen views in an Ember app for performance
MIT License
294 stars 29 forks source link

make it an ember-addon :) #29

Open stefanpenner opened 9 years ago

eviltrout commented 9 years ago

I plan to! Good idea :)

runspired commented 9 years ago

+1 I was literally just trying to figure out how to make this work without adding the file as one of my own components.

runspired commented 9 years ago

Took a stab at it.

https://github.com/runspired/ember-cloaking/tree/es6-conversion

I haven't built an addon before and I must be doing something wrong because in my project I still get 

Uncaught Error: <Ember._HandlebarsBoundView:ember1768> Handlebars error: Could not find property 'cloaked-collection' on object <ethereal@controller:conversations/index::ember1782>.
runspired commented 9 years ago

Got it working, turned out I'd just misunderstood which directory was getting merged with the main app's tree.

https://github.com/runspired/ember-cloaking/tree/es6-conversion

I've left a non es6 version in the main directory pointed to by bower for the moment, which should be changed to the output of a built version of the addon to remain compatible with non es6/ember-cli users.

If this looks good to you, I'll submit a pull request.

runspired commented 9 years ago

ping @eviltrout Thoughts? This would obviously need updated/redone for the new changes you just made, and a built version would need to be maintained, possibly using https://github.com/thomasboyt/browserify-es6-modules ?

eviltrout commented 9 years ago

I'd still like to do this, I just have been spread way too thin lately!

runspired commented 9 years ago

I needed this last month, so I went ahead and forked and did it. As I mentioned, it would need your new fixes (last 3 commits) and it needs the es6 browserify to be able to continue providing a globals based version for legacy. I'd be more than happy to contribute a PR to continue the discussion / enable review.

eviltrout commented 9 years ago

I would love a PR for this if you h ave time!

runspired commented 9 years ago

Accomplished by #32, this can be closed.