search

eviltrout / ember-cloaking

Support for not rendering offscreen views in an Ember app for performance
MIT License
294 stars 29 forks source link

es6 conversion #34

Open runspired opened 9 years ago

eviltrout commented 9 years ago

Awesome. I just took a peek and it seems like I'm not familiar with how it's set up. Are we supposed to use ember-cli to build it now? What are the instructions to create a new ember-cloaking for global usage?

runspired commented 9 years ago

Correct, this makes it a drop-in addon on for ember-cli, to use it all you have to do is be using ember-cli, it exposes the same helpers in the same manner as before.

The classes themselves are in /addon

They are imported into /app and exported again to make it easy for them to be imported and extended by the main app if needed without losing access to the originals. (This is per ember addon conventions).

The Brocfile.js of an addon exists only for the addon's own use (so using it to create a globals version is a pretty good use for it) and is not run by the app which installs it. I'm sure we could configure it to write out a globals version without too much trouble but I don't have experience with that.

Also a note: Ember-cli conventions have changed slightly since I began this conversion, I think there's a few tweaks that need to be made to dependencies / addon-main to be made, but it works without them.

SamSaffron commented 9 years ago

how far are we off being able to merge this in? @runspired do you still need more work here?

runspired commented 9 years ago

It's able to be merged but doesn't provide a mechanism for producing a globals build.

I'd also like to add tests but that can happen in a later sprint. This branch has been used in production for 5-6 months now.