eviltrout / ember-performance

A suite of tests for EmberJS to help with performance
140 stars 27 forks source link

Run tests against multiple versions of Ember #61

Closed GavinJoyce closed 9 years ago

GavinJoyce commented 9 years ago

/cc @rwjblue @stefanpenner

This adds support for running tests against multiple version of Ember and closes https://github.com/eviltrout/ember-performance/issues/59.

The TestSession now contains an array of TestGroups which have an associated Ember version and an array of TestItems.

image

Test results are now presented as ascii text only (closes https://github.com/eviltrout/ember-performance/issues/62):

image


I'll create some follow-up issues once this has merged:

rwjblue commented 9 years ago

This is looking really good, thanks for putting the time into it.

RE: the checklist above, let us know when you think this is ready to land and I will review again. We can make new issues for any remaining items (you mentioned some might be separate PR's).

stefanpenner commented 9 years ago

wohoo!

GavinJoyce commented 9 years ago

@rwjblue this is ready for review, thanks

eviltrout commented 9 years ago

Looks fantastic to me too! Thanks so much for this feature.

GavinJoyce commented 9 years ago

I've got a couple of PRs backing up, it would be great if someone could review this

rwjblue commented 9 years ago

Sorry for the delay, got a bit behind the last couple days.

GavinJoyce commented 9 years ago

No worries, thanks!