evilz / vscode-reveal

Revealjs vsCode extension
https://marketplace.visualstudio.com/items?itemName=evilz.vscode-reveal
MIT License
459 stars 146 forks source link

Support using style name instead of file name for highlight theme #1076

Closed unional closed 2 years ago

unional commented 2 years ago

Highlight themes name with two or more words doesn't work.

For example, Github Dark doesn't work, but github-dark does.

evilz commented 2 years ago

Yes this filename that you can find here: https://github.com/evilz/vscode-reveal/tree/master/libs/highlight.js/11.3.1/styles

unional commented 2 years ago

Yes, I want thinking about adding that to the README, so that it is more clear. However it would be better to support it as the README suggest (using double quotes "..." implies it takes two or more words such as "Github Dark")

evilz commented 2 years ago

Since there is the autocompletion it's not really a issue.

unional commented 2 years ago

oh~~, never noticed the autocompletion. thx!