Closed kchaloux closed 10 years ago
Looks good to me. I’ll wait and let @strager weigh in too.
Contbuild failed. Looks like you’re missing a containers
dependency in the Cabal file?
You need to teach me how to run those myself so I don't screw things up immediately. But yeah, it looks like a few things got left out somehow. There should be a containers == 0.5.*
in the build-depends for executable kitten
. There should also be two imports that seem to have gotten left out from the pull request somehow:
import Data.Set (Set)
import qualified Data.Set as S
That should fix the issue. Not terribly familiar with git, so you'll have to help me figure out how to amend things later.
Merged in 298e45888948a1251c4e3566ed19a5e20c4ed3aa.
Changed
load
to no longer crash when given a bad file.Also updated a few things based on strager's comments (didn't get around to factoring out the/ bits of the help text - not sure how to handle that gracefully).