:fire: Chore(actions): Delete dead code

roninjin10 commented 1 month ago

Description

Concise description of proposed changes

Testing

Explain the quality checks that have been done on the code changes

Additional Information

[ ] I read the contributing docs (if this is your first contribution)

Your ENS/address:

Summary by CodeRabbit

Bug Fixes
- Removed outdated and unnecessary code to streamline functionality.
- Updated documentation for functions to improve clarity and accuracy.
Documentation
- Removed several documentation files and type aliases to reflect recent code changes.
- Enhanced the README documentation for better understanding of the Address class and related functions.
- Deprecated client.tevmScript in favor of client.tevmContract for improved functionality.

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment

changeset-bot[bot] commented 1 month ago

🦋 Changeset detected

Latest commit: a358abc8e44e49615bf46138764ff0afeed36d59

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages

| Name | Type | | ------------------- | ----- | | @tevm/actions | Patch | | @tevm/cli | Patch | | @tevm/viem | Patch | | @tevm/decorators | Patch | | @tevm/memory-client | Patch | | @tevm/procedures | Patch | | @tevm/server | Patch | | tevm | Patch | | @tevm/ethers | Patch | | @tevm/http-client | Patch | | tevm-run | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

coderabbitai[bot] commented 1 month ago

[!CAUTION]

Review failed

The pull request is closed.

Walkthrough

The pull request introduces a cleanup in the @tevm/actions package, focusing on the removal of dead code and outdated documentation. Key functions and variables, including createError, zJsonRpcRequest, and zNetworkConfig, have been deleted, alongside their respective documentation files. Additionally, the README.md for the address module has been updated to reflect these changes, including the removal of the CreateContractAddressError type alias and enhancements to the documentation of the Address class and related functions.

Changes

File(s)	Change Summary
`.changeset/tricky-plums-admire.md`	Removed dead code and documentation for `createError`, `zJsonRpcRequest`, and `zNetworkConfig`.
`tevm/docs/address/README.md`	Removed `CreateContractAddressError` type alias; updated documentation for `Address` class and related functions.
`packages/server/docs/functions/createServer.md`	Deprecated `client.tevmScript` in favor of `client.tevmContract`; updated usage instructions.
`packages/server/src/createHttpHandler.spec.ts`	Updated import for `CallJsonRpcRequest` type from `@tevm/procedures` to `@tevm/actions`.
`packages/server/src/internal/parseRequest.js`	Introduced new Zod schema definitions for JSON-RPC requests.
`tevm/index.ts`	Restructured type exports; added several new types related to JSON-RPC requests.
`tevm/procedures/index.d.cts`	Removed all exports from `@tevm/procedures` module.
`tevm/procedures/index.d.ts`	Deleted module that re-exported all entities from `@tevm/procedures`.
`tevm/tsup.config.js`	Reformatted `dirs` array for improved readability; no functional changes.

Possibly related PRs

#1058: This PR introduces a DeployHandler, which is related to the removal of the createError function in the main PR, as both involve changes to the handling of contract deployment and error management.
#1062: This PR adds a deployHandler function to the tevm client, which is directly related to the changes in the main PR that involve the removal of functions and variables associated with contract deployment.
#1074: This PR addresses nonce handling in transactions, which may relate to the changes in the main PR that involve the removal of functions that could affect transaction processing.
#1076: This PR fixes issues with transaction removal from the mempool, which could be indirectly related to the cleanup efforts in the main PR that involve removing unused code.
#1154: This PR adds event support to the tevm, which may connect to the changes in the main PR that involve the removal of functions related to contract interactions.
#1450: This PR enhances test coverage for actions, which may relate to the changes in the main PR that involve the removal of certain functions and the need for improved testing around those functionalities.

🐇 In the code we find,
A cleanup, oh so kind!
Functions gone, docs too,
Streamlined paths for me and you.
Hopping forward, clear and bright,
Code's a garden, pure delight! 🌼

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: -- `I pushed a fix in commit , please review it.` -- `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: -- `@coderabbitai generate unit testing code for this file.` -- `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: -- `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` -- `@coderabbitai read src/utils.ts and generate unit testing code.` -- `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` -- `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

roninjin10 commented 1 month ago

#1452
#1451 👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @roninjin10 and the rest of your teammates on Graphite

evmts / tevm-monorepo