:white_check_mark: Test(actions): more test coverage

roninjin10 commented 1 month ago

Description

Concise description of proposed changes

Testing

Explain the quality checks that have been done on the code changes

Additional Information

[ ] I read the contributing docs (if this is your first contribution)

Your ENS/address:

Summary by CodeRabbit

New Features
- Introduced comprehensive test suites for various Ethereum JSON-RPC procedures, ensuring robust validation of transaction processing, account validation, and receipt retrieval functionalities.
- Enhanced type safety for JSON-RPC request parameters by implementing immutable tuples.
Bug Fixes
- Improved error handling across multiple procedures to ensure accurate responses for invalid requests and non-existent transactions.
Tests
- Added unit tests for procedures including processTx, validateSetAccountParams, ethAccountsProcedure, and others to cover both successful and error scenarios.

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment

changeset-bot[bot] commented 1 month ago

⚠️ No Changeset found

Latest commit: b1fa6f6b7e89806450e0957edc5b289ad80d3305

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

roninjin10 commented 1 month ago

#1455 👈
#1454
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @roninjin10 and the rest of your teammates on Graphite

coderabbitai[bot] commented 1 month ago

Walkthrough

This pull request introduces multiple test suites for various functions related to Ethereum transaction processing, validation, and retrieval. It enhances the codebase by adding comprehensive unit tests for functions such as processTx, validateSetAccountParams, and several JSON-RPC procedures, ensuring robust validation and error handling. Additionally, it modifies type declarations in the EthJsonRpcRequest.ts file to improve type safety by changing mutable tuples to immutable tuples.

Changes

File(s)	Change Summary
`packages/actions/src/Mine/processTx.spec.ts`	Introduced a test suite for the `processTx` function, validating transaction processing and receipt generation.
`packages/actions/src/SetAccount/validateSetAccountParams.spec.ts`	Added unit tests for `validateSetAccountParams`, covering various input validation scenarios and error handling.
`packages/actions/src/eth/EthJsonRpcRequest.ts`	Modified parameter types of several JSON-RPC request types to immutable tuples for enhanced type safety.
`packages/actions/src/eth/ethAccountsProcedure.spec.ts`	Created tests for `ethAccountsProcedure`, validating responses with and without an `id` in JSON-RPC requests.
`packages/actions/src/eth/ethGetTransactionByBlockHashAndIndexProcedure.spec.ts`	Introduced tests for retrieving transactions by block hash and index, covering both successful retrieval and error scenarios.
`packages/actions/src/eth/ethGetTransactionByBlockNumberAndIndexProcedure.spec.ts`	Added tests for retrieving transactions by block number and index, validating both successful and error responses.
`packages/actions/src/eth/ethGetTransactionByHashProcedure.spec.ts`	Established tests for `ethGetTransactionByHash`, ensuring correct retrieval of transaction details and handling of non-existent transactions.
`packages/actions/src/eth/ethGetTransactionReceiptProcedure.spec.ts`	Created tests for retrieving transaction receipts, validating successful and unsuccessful retrieval scenarios.
`packages/actions/src/eth/ethGetTransactionReceipt.spec.ts`	Introduced tests for `ethGetTransactionReceiptHandler`, covering successful retrieval and handling of non-existent receipts.
`packages/actions/src/eth/ethSignProcedure.spec.ts`	Added tests for `ethSignProcedure`, validating message signing and error handling for non-existent accounts.
`packages/actions/src/eth/getStorageAtHandler.spec.ts`	Established tests for `getStorageAtHandler`, covering various scenarios for retrieving storage values and error handling.
`packages/errors/package.json`	Updated the `scripts` section to add new commented-out testing scripts for `vitest`, while removing previous entries.
`packages/precompiles/src/logToEthjsLog.ts`	Modified the construction of `argsArray` for improved readability without changing logic.
`packages/actions/src/Call/callHandlerOpts.js`	Clarified the precedence in the conditional expression for `baseFeePerGas` without altering the functionality.

Possibly related PRs

#1049: This PR updates tests to use a different endpoint, which may relate to the testing framework used in the main PR for processTx.
#1058: Introduces a deployHandler, which may involve transaction processing similar to the processTx function tested in the main PR.
#1074: Fixes nonce handling in transactions, which is relevant to transaction processing and could relate to the processTx function.
#1076: Addresses transaction removal from the mempool, which is directly related to transaction processing and could impact the processTx function.
#1083: Implements eth_getLogs, which involves transaction logs and could relate to the processing of transactions in the main PR.
#1154: Introduces event handling in the TEVM, which may relate to transaction processing and the functionality being tested in the main PR.
#1450: Enhances test coverage for actions, which includes transaction-related functionalities that could overlap with the processTx function.
#1454: Comments out test scripts, which may indirectly relate to the testing framework used in the main PR.

🐰 In the meadow where rabbits play,
New tests hop in to save the day!
For transactions, they check and see,
Ensuring all works perfectly!
With every test, the code grows bright,
A joyful leap, oh what a sight! 🌼

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

:heart: Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

:placard: Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

evmts / tevm-monorepo