:bug: Fix: eth_sendRawTransaction bug and more tests

roninjin10 commented 1 month ago

Description

Concise description of proposed changes

Testing

Explain the quality checks that have been done on the code changes

Additional Information

[ ] I read the contributing docs (if this is your first contribution)

Your ENS/address:

Summary by CodeRabbit

New Features
- Enhanced error handling for transaction processing.
- Introduced new procedures for setting Ethereum account balances, chain ID, coinbase address, nonce, and storage.
Tests
- Added comprehensive test suites for various JSON-RPC procedures, including setting balances, nonce, and storage, as well as transaction processing, to ensure expected functionality and error handling.

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment

changeset-bot[bot] commented 1 month ago

🦋 Changeset detected

Latest commit: 2b0ff4d5f3eaccb324d7673fb8afe6e41c07e29e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 10 packages

| Name | Type | | ------------------- | ----- | | @tevm/actions | Patch | | @tevm/cli | Patch | | @tevm/ethers | Patch | | @tevm/viem | Patch | | @tevm/decorators | Patch | | @tevm/memory-client | Patch | | @tevm/server | Patch | | tevm | Patch | | @tevm/http-client | Patch | | tevm-run | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

coderabbitai[bot] commented 1 month ago

Walkthrough

A new patch for the "@tevm/actions" package has been introduced, adding multiple test suites for various JSON-RPC procedures, including anvilSetBalanceJsonRpcProcedure, anvilSetChainIdJsonRpcProcedure, and others. The ethSendRawTransactionHandler function has also been updated to improve error handling by replacing generic errors with specific InvalidTransactionError instances. These changes enhance the robustness and reliability of transaction processing and validation.

Changes

File(s)	Change Summary
`packages/actions/src/anvil/*.spec.ts`	Added test suites for `anvilSetBalanceJsonRpcProcedure`, `anvilSetChainIdJsonRpcProcedure`, `anvilSetCodeJsonRpcProcedure`, `anvilSetCoinbaseJsonRpcProcedure`, `anvilSetNonceJsonRpcProcedure`, and `anvilSetStorageAtJsonRpcProcedure`.
`packages/actions/src/eth/ethSendRawTransaction.spec.ts`	Introduced tests for `ethSendRawTransactionHandler`, covering various transaction scenarios.
`packages/actions/src/eth/ethSendRawTransactionHandler.js`	Improved error handling by replacing generic errors with `InvalidTransactionError`.

Possibly related PRs

#1058: The changes in this PR involve the createTransaction function, which may relate to transaction handling in the main PR's tests for setting balances.
#1074: This PR addresses nonce handling, relevant to the main PR's focus on transaction procedures and state management.
#1076: This PR fixes issues with transaction removal from the mempool, related to the main PR's focus on transaction handling and state validation.
#1430: This PR enhances the eth_estimateGas function, relevant to the main PR's focus on transaction procedures and state management.
#1450: This PR aims to add more test coverage to actions, aligning with the main PR's introduction of tests for the anvilSetBalanceJsonRpcProcedure.
#1455: This PR also focuses on enhancing test coverage, directly related to the main PR's introduction of a test suite for the anvilSetBalanceJsonRpcProcedure.

🐇 In the meadow, changes bloom,
Transactions now face less gloom.
Errors caught, tests in place,
A smoother path for every trace.
Hops of joy, let’s celebrate,
With code so fine, we elevate! 🌼

📜 Recent review details

**Configuration used: CodeRabbit UI** **Review profile: CHILL**

📥 Commits

Files that changed from the base of the PR and between 09b2ee97b796280cedb453bafb3ebaba6510872b and 2b0ff4d5f3eaccb324d7673fb8afe6e41c07e29e.

📒 Files selected for processing (8)

* packages/actions/src/anvil/anvilSetBalance.spec.ts (1 hunks) * packages/actions/src/anvil/anvilSetChainIdHandler.spec.ts (1 hunks) * packages/actions/src/anvil/anvilSetCodeProcedure.spec.ts (1 hunks) * packages/actions/src/anvil/anvilSetCoinbaseProcedure.spec.ts (1 hunks) * packages/actions/src/anvil/anvilSetNonceProcedure.spec.ts (1 hunks) * packages/actions/src/anvil/anvilSetStorageAtProcedure.spec.ts (1 hunks) * packages/actions/src/eth/ethSendRawTransaction.spec.ts (1 hunks) * packages/actions/src/eth/ethSendRawTransactionHandler.js (3 hunks)

🚧 Files skipped from review as they are similar to previous changes (8)

* packages/actions/src/anvil/anvilSetBalance.spec.ts * packages/actions/src/anvil/anvilSetChainIdHandler.spec.ts * packages/actions/src/anvil/anvilSetCodeProcedure.spec.ts * packages/actions/src/anvil/anvilSetCoinbaseProcedure.spec.ts * packages/actions/src/anvil/anvilSetNonceProcedure.spec.ts * packages/actions/src/anvil/anvilSetStorageAtProcedure.spec.ts * packages/actions/src/eth/ethSendRawTransaction.spec.ts * packages/actions/src/eth/ethSendRawTransactionHandler.js

--- Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

🪧 Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

roninjin10 commented 1 month ago

#1460 👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @roninjin10 and the rest of your teammates on Graphite

evmts / tevm-monorepo