search

evmts / tevm-monorepo

A library that enables next-generation UX and DX via putting an ethereum node in the browser and solidity in javascript
https://tevm.sh
MIT License
266 stars 26 forks source link

:test_tube: Test: Add more test coverage to actions #1466

Closed roninjin10 closed 1 month ago

roninjin10 commented 1 month ago

Description

Concise description of proposed changes

Testing

Explain the quality checks that have been done on the code changes

Additional Information

Your ENS/address:

Summary by CodeRabbit

Release Notes

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment | Name | Status | Preview | Updated (UTC) | | :--- | :----- | :------ | :------ | | **tevm-monorepo-tevm** | ⬜️ Ignored ([Inspect](https://vercel.com/evmts/tevm-monorepo-tevm/8HbEGwFPBdibqrHD1ECtMSzTcb5D)) | | Sep 29, 2024 0:41am |
changeset-bot[bot] commented 1 month ago

⚠️ No Changeset found

Latest commit: cb6cad54e9ffd81702c41b3fd78ba16d39014d16

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

coderabbitai[bot] commented 1 month ago

[!WARNING]

Rate limit exceeded

@roninjin10 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 19 minutes and 32 seconds before requesting another review.

⌛ How to resolve this issue? After the wait time has elapsed, a review can be triggered using the `@coderabbitai review` command as a PR comment. Alternatively, push new commits to this PR. We recommend that you space out your commits to avoid hitting the rate limit.
🚦 How do rate limits work? CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our [FAQ](https://coderabbit.ai/docs/faq) for further information.
📥 Commits Files that changed from the base of the PR and between bb288ba38a47ac98c1dbe116136d238dcba465e9 and cb6cad54e9ffd81702c41b3fd78ba16d39014d16.

Walkthrough

This pull request introduces a comprehensive suite of tests for various procedures related to Ethereum transaction handling, including debugTraceCallJsonRpcProcedure, debugTraceTransactionJsonRpcProcedure, and others. Significant modifications are made to the logic within debugTraceTransactionProcedure.js for better state root handling. Additionally, error handling improvements are implemented in ethGetLogsHandler.js, and new test cases enhance the coverage of transaction handling functionalities across multiple files.

Changes

File Path Change Summary
packages/actions/src/debug/debugTraceCallProcedure.spec.ts Introduced a test suite for debugTraceCallJsonRpcProcedure, validating its behavior with JSON-RPC requests and asserting response structure against snapshots.
packages/actions/src/debug/debugTraceTransactionProcedure.js Modified state root handling logic to include asynchronous checks and improved control flow for preforked blocks. Ensured state root is set on the VM clone before executing transactions.
packages/actions/src/debug/debugTraceTransactionProcedure.spec.ts Created a new test suite for debugTraceTransactionJsonRpcProcedure, verifying transaction tracing functionality and asserting expected results against snapshots.
packages/actions/src/eth/ethGetLogsHandler.js Simplified error handling by throwing original errors directly instead of wrapping them in ForkError. Adjusted log fetching logic to use nullish coalescing for better handling of undefined jsonRpcLogs.
packages/actions/src/eth/ethGetLogsHandler.spec.ts Implemented previously "todo" test cases for various log fetching scenarios, including block range, topic filtering, and pending blocks, enhancing overall test coverage.
packages/actions/src/eth/ethSendRawTransactionJsonRpcProcedure.spec.ts Added unit tests for ethSendRawTransactionJsonRpcProcedure, validating both modern and legacy transaction handling through signed transactions.
packages/actions/src/eth/ethSendTransactionHandler.spec.ts Established tests for ethSendTransactionHandler, covering simple transactions and contract interactions, ensuring correct functionality and state changes post-transaction.
packages/actions/src/eth/getBalanceHandler.spec.ts Enhanced test coverage for getBalanceHandler, validating balance fetching for various block tags and ensuring correct behavior in both forked and non-forked modes.
packages/actions/src/eth/getCodeHandler.spec.ts Added tests for fetching contract code from different blockchain forks, validating the returned code for specific contract addresses.

Possibly related issues

Possibly related PRs

🐰 In the land of code, where bunnies hop,
New tests sprout up, they never stop!
With traces and logs, we leap with delight,
Ensuring our functions work just right.
So here’s to the changes, let’s give a cheer,
For robust transactions, our vision is clear! 🐇✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
roninjin10 commented 1 month ago

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @roninjin10 and the rest of your teammates on Graphite Graphite