:bug: Fix: bug with gasLimit being set to block max

roninjin10 commented 3 weeks ago

Description

Concise description of proposed changes

Testing

Explain the quality checks that have been done on the code changes

Additional Information

[ ] I read the contributing docs (if this is your first contribution)

Your ENS/address:

Summary by CodeRabbit

Bug Fixes
- Corrected the handling of the gasLimit parameter in the @tevm/actions package to ensure accurate simulation behavior.
New Features
- Introduced a new TypeScript file for testing Ethereum transactions, enhancing the testing framework with a memory client setup.
Improvements
- Updated error handling and transaction execution logic in the executeCall function to enforce unconditional skipping of balance checks.

vercel[bot] commented 3 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment

changeset-bot[bot] commented 3 weeks ago

🦋 Changeset detected

Latest commit: 1fdedc61f7795146fc897dedf7fda53582536fc9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 10 packages

| Name | Type | | ------------------- | ----- | | @tevm/actions | Patch | | @tevm/cli | Patch | | @tevm/ethers | Patch | | @tevm/viem | Patch | | @tevm/decorators | Patch | | @tevm/memory-client | Patch | | @tevm/server | Patch | | tevm | Patch | | @tevm/http-client | Patch | | tevm-run | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

coderabbitai[bot] commented 3 weeks ago

[!WARNING]

Rate limit exceeded

@roninjin10 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 15 minutes and 48 seconds before requesting another review.

⌛ How to resolve this issue?
After the wait time has elapsed, a review can be triggered using the `@coderabbitai review` command as a PR comment. Alternatively, push new commits to this PR. We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?
CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our [FAQ](https://coderabbit.ai/docs/faq) for further information.

📥 Commits
Files that changed from the base of the PR and between 3c135fe26748197c5156f75585c8e9e8258ce621 and 1fdedc61f7795146fc897dedf7fda53582536fc9.

Walkthrough

The changes in this pull request implement a patch for the @tevm/actions package, addressing a bug with the gasLimit parameter during call simulations. The executeCall function's logic was modified to unconditionally skip balance checks by setting the skipBalance parameter to true. Additionally, a new TypeScript test file, gasFailing.ts, was added to test Ethereum transactions using a memory client, ensuring proper functionality and error handling in the context of the new gas limit behavior.

Changes

File Path	Change Summary
.changeset/tough-balloons-poke.md	Patch for `@tevm/actions` addressing `gasLimit` parameter bug during simulations.
packages/actions/src/Call/executeCall.js	Modified `executeCall` to always skip balance checks by setting `skipBalance` to `true`.
test/bench/src/gasFailing.ts	Added a new TypeScript test file for testing Ethereum transactions with a memory client.

Possibly related PRs

#1058: Introduces a patch for the createTransaction function with adjustments to gas limit handling.
#1187: Addresses a bug in parameter validation in the @tevm/actions module, related to handling parameters including gasLimit.
#1197: Fixes bugs in parameter validation in the @tevm/actions module, potentially connecting to gasLimit handling.
#1430: Fixes issues with the eth_estimateGas function, involving gas estimation relevant to gasLimit.
#1481: Addresses state overrides persistence, indirectly relating to parameter handling like gasLimit.

🐇 In the meadow where bunnies play,
A patch was made to save the day.
With gas limits fixed and balance checks gone,
Our tests now run smoothly, oh what fun!
Hopping along, we cheer with glee,
For every fix brings joy, you see!
🐰✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

🪧 Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

roninjin10 commented 3 weeks ago

#1489 👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @roninjin10 and the rest of your teammates on Graphite

evmts / tevm-monorepo