search

evo-mark / vue3-snackbar

Snackbar service for Vue3 applications
MIT License
49 stars 3 forks source link

feat: basic accessibility features #11

Closed lud-hu closed 2 months ago

lud-hu commented 2 months ago

vue3-snackbar is missing some basic accessibility features. This PR adds a proper aria role to the snackbar and also allows to set a custom aria label depending on the type of the message.

craigrileyuk commented 2 months ago

Thanks for the request. I'm not going to merge this one because using functions as props in Vue is generally not considered best practice (see Michael N. Thiessen's discussion on the subject).

However, I will take the suggestion and add equivalent functionality very shortly.

Thanks again.

lud-hu commented 4 days ago

Hi @craigrileyuk , did you already have time to look into this a11y issue?