search

evoWeb / recaptcha

TYPO3 Extension to make use of googles nocaptcha
GNU General Public License v2.0
5 stars 18 forks source link

#14 Resolves uncaught exception when no error code translation is given #15

Closed Xippo closed 6 years ago

Xippo commented 6 years ago

The commit b8b71de resolves the bug partially. We get still a uncaught exception (Fatal Error: Method TYPO3\CMS\Extbase\Validation\Error::__toString()) when we have no translation for the received API error.

garbast commented 6 years ago

Why not deliver the translations but instead introduce ugly messages?

Xippo commented 6 years ago

Good morning. Yeah this way is also possible but so its necessary to deliver all possible API responses and it must be kept uptodate. But there is still the possibility that a new introduced API response will break the extension until the extension is updated. So for me is better to have a working extension and a update can deliver the nice error messages without the need to hurry. There is already a great coverage of nice error descriptions for the most common error responses, so the occurrence of ugly errors will be minimal. This are my thoughts.

garbast commented 6 years ago

Please stick to the CGL of TYPO3 for future pull requests. I cleared them for this patch.