evoWeb / recaptcha

TYPO3 Extension to make use of googles nocaptcha
GNU General Public License v2.0
6 stars 18 forks source link

Question belong to the lang integration #22

Closed ayacoo closed 5 years ago

ayacoo commented 6 years ago

Hi!

we study https://developers.google.com/recaptcha/docs/display and see there is a doc for the language codes which will be add as parameter to the the url. E.g. https://www.google.com/recaptcha/api.js?hl?fr

It seems like the constant "lang" would not be used. We override the constant "api_server" and all is fine. Is this the right way?

Option A (easy): Remove "lang" constant and documentate the url behavior Option B: (medium): Combine "api_server" and "lang" if "lang" is given.

Thanks for your feedback!

garbast commented 6 years ago

You are right i will include the lang const next release

garbast commented 5 years ago

?hl= is now included but needs more testing because it seems as if its present even if the constant is empty

garbast commented 5 years ago

The behaviour is fixed in the latest version. There the ?hl= key is appended to the api.js inclusion.