evoWeb / recaptcha

TYPO3 Extension to make use of googles nocaptcha
GNU General Public License v2.0
6 stars 18 forks source link

requestFactory->createRequest doesn't work #61

Closed internetgalerie-github closed 1 year ago

internetgalerie-github commented 1 year ago

Hello, Using the reCAPTCHA extension in EXT:form-Forms gives an error on sending the form. Line 215 in Classes/Service/CaptchaService.php: got changed for V12 to the following: $response = $this->requestFactory->createRequest($this->configuration['verify_server'] . '?' . $params, 'POST');

But this doesn't work. First of all, the method takes the method as first parameter and the URI as the second, and doesn't return a response Object.

Changing it back to: $response = $this->requestFactory->request($this->configuration['verify_server'] . '?' . $params, 'POST');

Fixes the issue.

RTPAst commented 1 year ago

We have the same problem and have created a pull request.

garbast commented 1 year ago

after comparing core RequestFactory in 11 and 12 i reverted the change as suggestes back to $this->requestFactory->request

garbast commented 1 year ago

Fixed with commit eca0b3efaeb54b7ca28f07e8a0ee89c33a460d95