evoila / osb-checker-kotlin

This application is a generalized test program for service brokers. It runs rest calls against the defined service broker and checks if it behaves as expected to the service broker API specification. Tests are created dynamically based upon the service broker catalog or custom input by the operator.
https://www.evoila.de
Apache License 2.0
5 stars 6 forks source link

Treat organization_guid and space_guid as not required field in Provision request #5

Open FelisiaM opened 5 years ago

FelisiaM commented 5 years ago

What is the problem? Provision request spec defines organization_guid and space_guid as required fields. However, these fields have been deprecated in favour of using context for quite a while now Nov 2017

Given that they are deprecated for a while it would be good to not have them being tested as required fields.

At the same time, there is an OSBAPI spec issue opened here to make it explicit that those are not required.

chbrinker commented 5 years ago

Hi Felisia,

thanks for raising that. Unfortunately, we have to check the service brokers to being implemented accordingly to the OSBAPI spec. So as long as this is spec we have to check for it. So I am here on the same page with @mattmcneeney. But I think we may should weaken the enforcement at that fields or raise a deprecation warning. I will discuss it with the others here at the team and reach back out to you.

chbrinker commented 5 years ago

@FelisiaM We put raising warnings on our road map. If we implemented that we will add deprecation warnings. I would close this issue for now, if you have nothing to add?