search

evollu / react-native-fcm

react native module for firebase cloud messaging and local notification
MIT License
1.73k stars 682 forks source link

Safe FirebaseMessaging usage #1040

Closed punksta closed 6 years ago

punksta commented 6 years ago

when native functions throw exceptions, app won't crash

badrange commented 6 years ago

Same problem also without using Android Studio: 

/Users/bernt/project/node_modules/react-native-fcm/android/src/main/java/com/evollu/react/fcm/FIRMessagingModule.java:218: error: exception IOException is never thrown in body of corresponding try statement
        } catch (IOException e) {
          ^
/Users/bernt/project/node_modules/react-native-fcm/android/src/main/java/com/evollu/react/fcm/FIRMessagingModule.java:229: error: exception IOException is never thrown in body of corresponding try statement
        } catch (IOException e) {
          ^
punksta commented 6 years ago

my bad. try to use older version. I will fix it tonight.

evollu commented 6 years ago

sorry fixed in 16.2.3