search

evollu / react-native-fcm

react native module for firebase cloud messaging and local notification
MIT License
1.73k stars 681 forks source link

accept sound param when creating notification channel #1083

Open nol13 opened 5 years ago

nol13 commented 5 years ago

Accept sound param when creating notification channel, fixes https://github.com/evollu/react-native-fcm/issues/565, at least as it relates to android oreo+, based off the stackoverflow link posted by @illestrater

Also added a check to not crash if priority isn't set since that is supposed to be optional.

First time I've touched Java in a while, but it seems to be working pretty well.