search

evollu / react-native-fcm

react native module for firebase cloud messaging and local notification
MIT License
1.73k stars 681 forks source link

Consider re-openning this repo #1131

Open cargallo opened 4 years ago

cargallo commented 4 years ago

react-native-firebase is no longer developing a solution for notification in V6 version. So, please reconsider the repo deprecation

phatlaunchdeck commented 4 years ago

I would +1 this so bad, I'm still using this repo in my 10+ on-going projects right now

Desintegrator commented 4 years ago

+1

danielvportlandia commented 4 years ago

+1

vomchik commented 4 years ago

+1

temitope commented 4 years ago

Here is a link explaining the drop in support for notifications that came from the RNF v6 jump.

https://github.com/invertase/react-native-firebase/issues/2566#issuecomment-562700412

This repo is quite relevant and valuable to the community. Not sure if @evollu is interested in resurecting for open source input.

phatlaunchdeck commented 4 years ago

@evollu You have any thinking over this yet?

vomchik commented 4 years ago

FYI: in react-native-firebae v6.4.0 was add two methods for notifacion, getInitialNotification and onNotofocationOpened. I think it will be enough for most apps.

phatlaunchdeck commented 4 years ago

@vomchik I haven't used react-native-firebase for a while now, but by the sound of those methods, I would assume that onNotificationOpened only get triggered when the user taps onto the notification, and that is not enough since on all of my projects, the data needs processing as soon as notification comes in, not when the user taps on it.

vomchik commented 4 years ago

I see, but if you want to catch a incoming notification in the foreground please use onMessage handler.

phatlaunchdeck commented 4 years ago

Well that would do for the foreground case, but what if when the app is running but in the background? Any method for that or would the onMessage() handle that case too?

vomchik commented 4 years ago

As far I remember it also will be handled by onMessage, please check a documentation 🕵️‍♂️

phatlaunchdeck commented 4 years ago

Ah if so that would be nice, I'll check it out, thanks!

However, I still would like @evollu to re-open this repo regardless. I've been forking this repo to fix AndroidX support along with some other bug fixes but if he's not coming back I might have to dig up my rusty Java skill from college again to add support for new features of FCM.