search

evollu / react-native-firebase-analytics

React native bridge for firebase analytics
MIT License
206 stars 54 forks source link

Support the setScreenName method #34

Closed mikemonteith closed 7 years ago

mikemonteith commented 7 years ago

https://firebase.google.com/docs/reference/ios/firebaseanalytics/api/reference/Classes/FIRAnalytics#/c:objc(cs)FIRAnalytics(cm)setScreenName:screenClass:

Tested on iOS but not android.

evollu commented 7 years ago

@mikemonteith I'm getting warning setScreenName:screenClass: must be called after a view controller has appeared do you have this error?

mikemonteith commented 7 years ago

Sorry, I haven't seen that warning. Are you trying to use the setScreenName method before the app has mounted?

evollu commented 7 years ago

Are you using NavigationExperimental?

mikemonteith commented 7 years ago

Yes, but the setScreenName code was in a higher-level component. I call setScreenName(routeName) when my navigation state changes.

sibelius commented 7 years ago

@mikemonteith I think that there are an issue on android https://github.com/evollu/react-native-firebase-analytics/issues/36

bitcoinvsalts commented 7 years ago

+1

jordanmkoncz commented 7 years ago

Just an FYI for anyone reading this pull request, there's an issue https://github.com/evollu/react-native-firebase-analytics/issues/48 regarding the setScreenName:screenClass: must be called after a view controller has appeared error.