search

evollu / react-native-firebase-analytics

React native bridge for firebase analytics
MIT License
206 stars 54 forks source link

missing screenClass on screenView #71

Closed sibelius closed 6 years ago

sibelius commented 6 years ago

based on this https://firebase.google.com/docs/reference/android/com/google/firebase/analytics/FirebaseAnalytics#setCurrentScreen(android.app.Activity, java.lang.String, java.lang.String)

and this one https://github.com/invertase/react-native-firebase/blob/master/lib/modules/analytics/index.js#L77

evollu commented 6 years ago

@sibelius do you think it makes more sense to just deprecate this lib and use react-native-firebase?

sibelius commented 6 years ago

maybe this is a good idea

what about https://github.com/evollu/react-native-fcm?

evollu commented 6 years ago

@sibelius that will still be maintained because it has more features than firebase

sibelius commented 6 years ago

gonna move to this one instead https://github.com/invertase/react-native-firebase

tks

sibelius commented 6 years ago

what about merging react-native-fcm with react-native-firebase

are they willing to add all the features from react-native-fcm there?