Stencil generator does not give an error message for invalid image files, instead stuck at loading

evolus / pencil

The Pencil Project's unique mission is to build a free and opensource tool for making diagrams and GUI prototyping that everyone can use.

http://pencil.evolus.vn

GNU General Public License v2.0

9.05k stars 717 forks source link

Stencil generator does not give an error message for invalid image files, instead stuck at loading #646

Open StefanLobbenmeier opened 4 years ago

StefanLobbenmeier commented 4 years ago

For example in the case described here https://github.com/evolus/pencil/issues/645, when an image is not valid (wrong file ending) no error is produced but instead it is stuck at loading without any UI hint that an error has occured

Relevant code where Error should be thrown in else: https://github.com/evolus/pencil/blob/3ed2b8a0ba9df6cd1ecb02d965c980567048197b/app/views/tools/StencilGeneratorDialog.js#L270

StefanLobbenmeier commented 4 years ago

Suggestion for fix: call callback with all images that have been sucessfully read and error so they can be displayed in the UI.