Search function - Githubissues

evoluteur / evolutility-ui-react

Framework for building CRUD UIs for Hasura GraphQL with models rather than code.

https://evoluteur.github.io/evodemo/

GNU Affero General Public License v3.0

113 stars 30 forks source link

Search function #2

Closed pilgrim2go closed 5 years ago

pilgrim2go commented 6 years ago

Hi,

Thanks for your great app. I'm able to add new model with less effort.

I have some questions

Do you support search functionality? I can't find any example using search. I also find that the search flag is commented.
Since I'm very new to react, can you give me a guidance to add search to a specific model? I have one model only so we can accept hard approach.

Thanks, Van

evoluteur commented 6 years ago

Hi Van,

The search is not implemented yet. I would like to upgrade to React 16.5.2 first and it is a big change...

evoluteur commented 5 years ago

Working on it...

pymeup commented 5 years ago

Hi Olivier,

Is it possible to have an estimate for when the Search functionality will be in place?

Thank you, Costin V.

pymeup commented 5 years ago

Hi @evoluteur ,

Kind reminder.

Thank you! Costin V

evoluteur commented 5 years ago

Sorry, I thought I would find time to finish it. I'll checkin something within a week or 2 but I do not know when it will be really complete.

pymeup commented 5 years ago

ok , @evoluteur .

Looking forward to any upgrades as this implementation will be a great enhancement.

Thank you!

evoluteur commented 5 years ago

I checked-in the search feature. It doesn't include "lov" fields yet but gives you basic search for fields with string values. Fields that are searched are specified in the models server-side. Let me know how it's working for you.

pymeup commented 5 years ago

Hi Olivier,

Thank you for the update! Looking good!

Search is definitely helpful but Is filtering also a thing you are considering?

I think in the context of having to select from multiple columns the filtering would be a considerable advantage.

Nevertheless, really thanks for the implementation!

All the best, Costin V.

Sent with ProtonMail Secure Email.

‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐ On Monday, March 11, 2019 9:19 AM, Olivier Giulieri notifications@github.com wrote:

I checked-in the search feature. It doesn't include "lov" fields yet but gives you basic search for fields with string values. Fields that are searched are specified in the models server-side. Let me know how it's working for you.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

evoluteur commented 5 years ago

I plan to have both search and filters. Here is my prototype for filters: https://github.com/evoluteur/structured-filter-react

david-pfx commented 5 years ago

Which says:

React component for structured queries like "Contacts where Firstname starts with 'A' and Birthday before 1/1/2000 and State in (CA, NY, FL)"...

That would not be my choice. I would much prefer (as in Excel and others) to set a condition and sort on each column.

evoluteur commented 5 years ago

Yes, a filter on each column is very convenient. I would still need the "query builder" style filter for cases where there is no table like in charts (which will use filters) or "saved queries". Ideally I should have both (in addition to search).