evolution-cms / evolution

Welcome to the new evolution of MODX Evolution!
GNU General Public License v3.0
260 stars 95 forks source link

Impossible to install SimpleGallery #1046

Open Spheerys opened 5 years ago

Spheerys commented 5 years ago

Hi,

I have an old Evo website which using MaxiGallery which is not well coded for php7.2 I planed to change the gallery to SimpleGAllery but this extra doens't want to be installed. I have no error message during installation, neither on the Evo Log On GitHub, there is no posisbilty to create an issue on the SimpleGallery repository, so I can here to see if I'm the only one to encounter an issue with this extra or if there is a real problem...

Thanks for your feedbacks :)

Spheerys commented 5 years ago

I made a manual update to MaxiGallery 0.6 and that solved my gallery issue with PHP7.2 However, I don't understand why SimpleGallery refuse to be installed....

user83743 commented 5 years ago

Hi Spheerys @Spheerys . Do you mind outlining what changes you made to get maxigallery working on php7.2. We are on evo 1.4.2 and php 7.1 . if we change to php 7.2 any page that does not have a maxigallery works fine, but the maxigallery pages go blank white and in the evo cms error log we see:

Snippet - MaxiGallery / PHP Parse Error - System Events

Error

Event Id: 0 Source: Snippet - MaxiGallery / PHP Parse Error Date: 22-09-2019 07:19:53 User:

Trying to get property 'action' of non-object « Evo Parse Error » Error : Use of undefined constant MAXIGALLERY_PATH - assumed 'MAXIGALLERY_PATH' (this will throw an Error in a future version of PHP) Error information
ErrorType[num] WARNING[2] File /home/ggmservices/public_html/xxxxxxxxxxxxxxxx.com/manager/includes/document.parser.class.inc.php(1926) : eval()'d code Line 66 Current Snippet MaxiGallery

Basic info
REQUEST_URI http://www.xxxxxxxxxxxxxxx.com:443/durabeds-mattresses.html Resource [51] Durabeds Mattresses Referer https://www.xxxxxxxxxxxxxxx.com/bed-frames.html User Agent Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/77.0.3865.90 Safari/537.36 IP 89.101.66.113 Current time 2019-09-22 07:19:53

Benchmarks
MySQL 0.0008 s (8 Requests) PHP 0.0163 s Total 0.0170 s Memory 3.617317199707 mb

Backtrace DocumentParser->executeParser() index.php on line 139 DocumentParser->prepareResponse() manager/includes/document.parser.class.inc.php on line 2825 DocumentParser->outputContent() manager/includes/document.parser.class.inc.php on line 2949 DocumentParser->parseDocumentSource(string $var1) manager/includes/document.parser.class.inc.php on line 897 DocumentParser->evalSnippets(string $var1) manager/includes/document.parser.class.inc.php on line 2676 DocumentParser->_get_snip_result(string $var1) manager/includes/document.parser.class.inc.php on line 1989 DocumentParser->evalSnippet(string $var1, array $var2) manager/includes/document.parser.class.inc.php on line 2077 eval() manager/includes/document.parser.class.inc.php on line 1926