search

evolution-events / Artaxerxes

Evolution Events information system
http://www.evolution-events.nl
4 stars 0 forks source link

Ask for firstname/lastname on account creation #46

Closed matthijskooijman closed 4 years ago

matthijskooijman commented 6 years ago

Currently, the firstname/lastname is left empty when a local account is registered. For social accounts, this information is filled in (when available).

For a local account this info should probably be asked on registration. This might require a custom signup form (there does not seem to be a config for "additional signup fields" at least).

Should we make first_name and last_name required fields on User?

ReneB commented 6 years ago

Yes - if this does not make the signup process too complicated to implement properly. But how do we ensure that they will be filled when the data is not available in the social account?

ReneB commented 4 years ago

How could we go about doing this? Can we add it to the registration flow, so the first page of "prepare registration" would ask you about your first and last name?

matthijskooijman commented 4 years ago

That would probably be the easiest, along with the rest of the personal details.

matthijskooijman commented 4 years ago

It would make sense to eventually ask this on account creation, but even then it would make sense to at least show, and probably allow changing, the name during event registration as well.

matthijskooijman commented 4 years ago

I've created #81 for asking the name during event (pre)registration, this issue is now only about asking during account creation. Only #81 is needed for the MVP, but while implementating something else, it was easy to immediately also implement this.