evolution-gaming / akka-effect

Cats-Effect & Akka interop
MIT License
55 stars 5 forks source link

SHRIKE-54: expose notion of `persistent` snapshot in backward-compatible way #321

Closed dfakhritdinov closed 4 months ago

dfakhritdinov commented 4 months ago

Done as backward-compatible alternative to https://github.com/evolution-gaming/akka-effect/pull/318

The PR should be merged after https://github.com/evolution-gaming/akka-effect/pull/319 to avoid breaking changes & major version bump.

dfakhritdinov commented 4 months ago

@mr-git, I'm thinking about disabling MiMa again because on minor version bump MiMa complains that modules without changes API should not have the bump:

[error] Incompatibilities with dependencies of akka-effect-testkit:4.1.4-SNAPSHOT
[error]   com.evolutiongaming:akka-effect-actor_2.13: incompatible version change from 4.1.4-SNAPSHOT to 4.2.0 (compatibility: strict semantic versioning)
[error] Incompatibilities with dependencies of akka-effect-persistence-api:4.1.4-SNAPSHOT
[error]   com.evolutiongaming:akka-effect-actor_2.13: incompatible version change from 4.1.4-SNAPSHOT to 4.2.0 (compatibility: strict semantic versioning)
[error] Incompatibilities with dependencies of akka-effect-cluster:4.1.4-SNAPSHOT
[error]   com.evolutiongaming:akka-effect-actor_2.13: incompatible version change from 4.1.4-SNAPSHOT to 4.2.0 (compatibility: strict semantic versioning)
[error] Incompatibilities with dependencies of akka-effect-persistence:4.1.4-SNAPSHOT
[error]   com.evolutiongaming:akka-effect-actor_2.13: incompatible version change from 4.1.4-SNAPSHOT to 4.2.0 (compatibility: strict semantic versioning)
[error]   com.evolutiongaming:akka-effect-persistence-api_2.13: incompatible version change from 4.1.4-SNAPSHOT to 4.2.0 (compatibility: strict semantic versioning)
[error] Incompatibilities with dependencies of akka-effect-cluster-sharding:4.1.4-SNAPSHOT
[error]   com.evolutiongaming:akka-effect-actor_2.13: incompatible version change from 4.1.4-SNAPSHOT to 4.2.0 (compatibility: strict semantic versioning)
[error]   com.evolutiongaming:akka-effect-cluster_2.13: incompatible version change from 4.1.4-SNAPSHOT to 4.2.0 (compatibility: strict semantic versioning)
[error]   com.evolutiongaming:akka-effect-persistence-api_2.13: incompatible version change from 4.1.4-SNAPSHOT to 4.2.0 (compatibility: strict semantic versioning)
[error]   com.evolutiongaming:akka-effect-persistence_2.13: incompatible version change from 4.1.4-SNAPSHOT to 4.2.0 (compatibility: strict semantic versioning)
[error] Incompatibilities with dependencies of akka-effect-eventsourcing:4.1.4-SNAPSHOT
[error]   com.evolutiongaming:akka-effect-actor_2.13: incompatible version change from 4.1.4-SNAPSHOT to 4.2.0 (compatibility: strict semantic versioning)
[error]   com.evolutiongaming:akka-effect-persistence-api_2.13: incompatible version change from 4.1.4-SNAPSHOT to 4.2.0 (compatibility: strict semantic versioning)
[error]   com.evolutiongaming:akka-effect-persistence_2.13: incompatible version change from 4.1.4-SNAPSHOT to 4.2.0 (compatibility: strict semantic versioning)

That is super annoying, we should do something with MiMa

mr-git commented 4 months ago

I cannot repeat the issues with MiMa check with compatibility: strict semantic versioning message...