Corrections and improvements

[evolutionsoftswiss]

Hints

You can checkout and build this branch state with "mvn clean package". I've attached my local build of this branch state too. This should fix and improve Issues with players containing dots in their names, should support Antes and treat the hero hole cards corrctly. I've got no possibility to check the end import results for Hold'em hands. PockerTracker could import your csv from Issue #8 without errors beside the unsupported game type.

It would be good to check the results on your side with this version.

Commit/Push

• Fix Issue #7 support player names with dots without mapping
• Support for antes according to Issue #8
• Fix Issue #9 Improve own "hero" hole cards treatment with "dealt to" instead of additional, most often incorrect, showdown action

handhistory-converter-0.2.2-SNAPSHOT-program.zip

[Deckhole]

This is fantastic news!

Have you verified that running it twice and straddles work?

I think running it twice doesn’t produce errors, but also doesn’t properly document both boards for Trackers. I’ll double-check and send examples when determining if there is an issue.

That nickname converter you included in the code is a fantastic feature by-the-way!

Thanks again.

Went through the code but my Java is way rusty.

On Sat, Oct 23, 2021 at 4:40 AM evolutionsoftswiss @.***> wrote:

Hints

You can checkout and build this branch state with "mvn clean package". I've attached my local build of this branch state too. This should fix and improve Issues with players containing dots in their names, should support Antes and treat the hero hole cards corrctly. I've got no possibility to check the end import results for Hold'em hands. PockerTracker could import your csv from Issue #8 https://github.com/evolutionsoftswiss/pokernow-handhistory-converter/issues/8 without errors beside the unsupported game type.

It would be good to check the results on your side with this version. Commit/Push

• Fix Issue #7 https://github.com/evolutionsoftswiss/pokernow-handhistory-converter/issues/7 support player names with dots without mapping
• Support for antes according to Issue #8 https://github.com/evolutionsoftswiss/pokernow-handhistory-converter/issues/8
• Fix Issue #9 https://github.com/evolutionsoftswiss/pokernow-handhistory-converter/issues/9 Improve own "hero" hole cards treatment with "dealt to" instead of additional, most often incorrect, showdown action

handhistory-converter-0.2.2-SNAPSHOT-program.zip https://github.com/evolutionsoftswiss/pokernow-handhistory-converter/files/7402517/handhistory-converter-0.2.2-SNAPSHOT-program.zip

You can view, comment on, or merge this pull request online at:

https://github.com/evolutionsoftswiss/pokernow-handhistory-converter/pull/10 Commit Summary

• Corrections and improvements https://github.com/evolutionsoftswiss/pokernow-handhistory-converter/pull/10/commits/fda72f1971d38203a44e59c78f11f7fd1a86b267

File Changes

• M README.md https://github.com/evolutionsoftswiss/pokernow-handhistory-converter/pull/10/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5 (1)
• M conversion.properties https://github.com/evolutionsoftswiss/pokernow-handhistory-converter/pull/10/files#diff-02d05ec0b448beaba647d5022f3f8b12905d93c6b6c5a63359f2c95b43349d66 (2)
• M src/main/java/ch/evolutionsoft/poker/pokernow/PokernowConstants.java https://github.com/evolutionsoftswiss/pokernow-handhistory-converter/pull/10/files#diff-3b102f89b35e9d21e826b8446ea59d0619246758e53f9f2eb699601ec0b004ef (3)
• M src/main/java/ch/evolutionsoft/poker/pokernow/PokernowSingleHandConverter.java https://github.com/evolutionsoftswiss/pokernow-handhistory-converter/pull/10/files#diff-aece0fdc7ba7b78a567cf7be97466798d3e97d0853521664b9e9d5ffc0e30869 (41)
• M src/main/java/ch/evolutionsoft/poker/pokernow/PokerstarsConstants.java https://github.com/evolutionsoftswiss/pokernow-handhistory-converter/pull/10/files#diff-b7c480a858a94ad854cb762145f35dea71330d8c15ba15b13ce0692cbec71bf2 (1)

Patch Links:

- https://github.com/evolutionsoftswiss/pokernow-handhistory-converter/pull/10.patch

https://github.com/evolutionsoftswiss/pokernow-handhistory-converter/pull/10.diff

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/evolutionsoftswiss/pokernow-handhistory-converter/pull/10, or unsubscribe https://github.com/notifications/unsubscribe-auth/AV7NSYK4G4NQCWFGIT4BLWDUIJYHLANCNFSM5GSAWH6Q . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.