Hand history not being properly converted.

[andrewzhang2001]

I ran the hand history converter on 3 of my files and then uploaded them to Pokerstars. In one of the three files, I got 14 errors that looked like this.

04:27:34 pm: Error: PokerStars: Invalid pot size (66.00 vs pot: 33.00 rake: 0.00 jpt: 0.00) for hand #20231012235340107 (Line #4892) 04:27:34 pm: Error: PokerStars: Invalid pot size (11.00 vs pot: 5.50 rake: 0.00 jpt: 0.00) for hand #20231012235340112 (Line #5108) 04:27:34 pm: Error: PokerStars: Invalid pot size (6.50 vs pot: 3.25 rake: 0.00 jpt: 0.00) for hand #20231012235340114 (Line #5200) ...

Where I get an invalid pot size double the actual pot size.

Looking into the converted hand histories, it seems like two players would collect the pot.

PokerStars Hand #20231012235340107: No Limit Texas Hold'em ($0.25/$0.5 USD) - 2023/10/13 01:39:37 CET Table 'Poker Now' 10-max Seat #8 is the button Seat 2: home ($185.19 in Chips) Seat 3: commandercuhz ($153.13 in Chips) Seat 4: p00ri ($85.80 in Chips) Seat 6: rk ($201.67 in Chips) Seat 7: Woo ($25.25 in Chips) Seat 8: Josh ($173.73 in Chips) Seat 9: roger ($63.47 in Chips) Seat 10: Mark ($50.00 in Chips) roger: posts small blind $0.25 Mark: posts big blind $0.50 HOLE CARDS Dealt to commandercuhz [4h Qs] home: raises $1.0 to $1.50 commandercuhz: folds p00ri: folds rk: raises $3.5 to $5.00 Woo: folds Josh: calls $5.00 roger: calls $4.75 Mark: folds home: calls $3.5 FLOP [4s 2h Qd] roger: checks home: checks rk: bets $6.25 Josh: folds roger: calls $6.25 home: folds TURN 4s 2h Qd [8h] roger: checks rk: bets $16.00 roger: folds Uncalled bet ($16.00) returned to rk SHOW DOWN rk collected $33.00 from pot SUMMARY Total pot $33.0 | Rake $0 Board [4s 2h Qd 8h] Seat 2: home folded Seat 3: commandercuhz folded Seat 4: p00ri folded Seat 6: rk collected ($33.00) Seat 7: Woo folded Seat 8: Josh folded Seat 9: roger folded Seat 10: Mark collected ($33.00)

Here is the raw data from the Pokernow csv log

"-- ending hand #107 --",2023-10-13T01:40:45.769Z,169716124576902 """rk @ PIUrT-JXRC"" collected 33.00 from pot",2023-10-13T01:40:45.769Z,169716124576901 "Uncalled bet of 16.00 returned to ""rk @ PIUrT-JXRC""",2023-10-13T01:40:45.769Z,169716124576900 """roger @ ljE4ap5W"" folds",2023-10-13T01:40:44.888Z,169716124488800 """rk @ PIUrT-JXRC"" bets 16.00",2023-10-13T01:40:32.785Z,169716123278500 """roger @ ljE4ap5W"" checks",2023-10-13T01:40:19.557Z,169716121955700 "Turn: 4♠, 2♥, Q♦ [8♥]",2023-10-13T01:40:18.930Z,169716121893000 """home @ tSDnIpzkyp"" folds",2023-10-13T01:40:18.117Z,169716121811700 """roger @ ljE4ap5W"" calls 6.25",2023-10-13T01:40:17.154Z,169716121715400 """Josh @ sNxjYxpyu2"" folds",2023-10-13T01:40:14.135Z,169716121413500 """rk @ PIUrT-JXRC"" bets 6.25",2023-10-13T01:40:11.512Z,169716121151200 """home @ tSDnIpzkyp"" checks",2023-10-13T01:40:05.831Z,169716120583100 """roger @ ljE4ap5W"" checks",2023-10-13T01:40:04.833Z,169716120483300 "Flop: [4♠, 2♥, Q♦]",2023-10-13T01:39:59.528Z,169716119952800 """home @ tSDnIpzkyp"" calls 5.00",2023-10-13T01:39:58.714Z,169716119871400 """Mark @ CmLxa8z8dy"" folds",2023-10-13T01:39:57.309Z,169716119730900 """roger @ ljE4ap5W"" calls 5.00",2023-10-13T01:39:56.290Z,169716119629000 """Josh @ sNxjYxpyu2"" calls 5.00",2023-10-13T01:39:54.373Z,169716119437300 """Woo @ 8RVSnjXzVQ"" folds",2023-10-13T01:39:51.337Z,169716119133700 """rk @ PIUrT-JXRC"" raises to 5.00",2023-10-13T01:39:44.500Z,169716118450000 """p00ri @ 3jJWq1nqHB"" folds",2023-10-13T01:39:41.907Z,169716118190700 """andrew @ I02UkToftt"" folds",2023-10-13T01:39:41.026Z,169716118102600 """home @ tSDnIpzkyp"" raises to 1.50",2023-10-13T01:39:40.122Z,169716118012200 """Mark @ CmLxa8z8dy"" posts a big blind of 0.50",2023-10-13T01:39:37.254Z,169716117725412 """roger @ ljE4ap5W"" posts a small blind of 0.25",2023-10-13T01:39:37.254Z,169716117725411 "Your hand is 4♥, Q♠",2023-10-13T01:39:37.254Z,169716117725404 "Player stacks: #2 ""home @ tSDnIpzkyp"" (185.19) | #3 ""andrew @ I02UkToftt"" (153.13) | #4 ""p00ri @ 3jJWq1nqHB"" (85.80) | #6 ""rk @ PIUrT-JXRC"" (201.67) | #7 ""Woo @ 8RVSnjXzVQ"" (25.25) | #8 ""Josh @ sNxjYxpyu2"" (173.73) | #9 ""roger @ __ljE4ap5W"" (63.47) | #10 ""Mark @ CmLxa8z8dy"" (50.00)",2023-10-13T01:39:37.254Z,169716117725402 "-- starting hand #107 (id: yyrlu6nggtxv) (No Limit Texas Hold'em) (dealer: ""Josh @ sNxjYxpyu2"") --",2023-10-13T01:39:37.254Z,169716117725401

This occured in 14/195 hands in this one file. In my two other files with 290 hands and 171 hands, this occurred 0 times. I'd be happy to upload the entire Pokernow CSV log if you need it!

[evolutionsoftswiss]

Thanks for describing the issue, Andrew. I'll look into this the next days. My first guess is the rk name being part of the other Mark name leading to invalid results. What you could try in the meantime with the problematic file, is to use a mapped name for rk, not being a substring of another name.

[evolutionsoftswiss]

Andrew, can you confirm that the potential new version here resolves the problems with your file ? handhistory-converter-0.2.6-program.zip

[andrewzhang2001]

Hey swiss,

TLDR: This seemed to have fixed the problems with all the previous files! However, there is a problem with having a parenthesis in the name: i.e. "Big C (host)"

The details: Unfortunately, the most recent file had a lot of bugs that seemed more erratic than the previous one. Just as an example, the "SHOW DOWN" section seems incomplete in this hand.

PokerStars Hand #2023102222593135: No Limit Texas Hold'em ($0.25/$0.5 USD) - 2023/10/22 23:32:10 CET Table 'Poker Now' 10-max Seat #4 is the button Seat 1: pri ($198.50 in Chips) Seat 2: Jack Seven ($74.14 in Chips) Seat 3: Yongj ($97.25 in Chips) Seat 4: fortnite ($21.00 in Chips) Seat 6: Big C ($host in Chips) ($65.00 in Chips) Seat 7: dwai ($66.99 in Chips) Seat 8: roger ($29.37 in Chips) Seat 10: QQQ ($108.00 in Chips) Big C (host): posts small blind $0.25 dwai: posts big blind $0.50 HOLE CARDS roger: folds QQQ: folds pri: folds Jack Seven: folds Yongj: folds fortnite: calls $0.50 Big C (host): raises $2.0 to $2.50 dwai: folds fortnite: calls $2.0 FLOP [3c 6d Td] Big C (host): bets $3.00 fortnite: folds Uncalled bet ($3.00) returned to Big C (host) SHOW DOWN Big C SUMMARY Total pot $5.5 | Rake $0 Board [ 3c 6d Td] Seat 1: pri folded Seat 2: Jack Seven folded Seat 3: Yongj folded Seat 4: fortnite folded Seat 6: Big C ($host in Chips) folded Seat 7: dwai folded Seat 8: roger folded Seat 10: QQQ folded

I got 84/233 hands errored in this file. The errors looked like this:

A pattern I can see is that after all the "Warning: Big Blind Not Posted" messages, the next hand also raised an error. Looking through the logs, there was never actually a Big Blind that wasn't posted. Also, the warnings are split up every ~500 lines which is roughly an orbit of hand history since I was playing 10-max, so maybe one of the names at a certain position is messing with the back-end logic.

After reviewing the file, I noticed that the host of the game: Big C (host) gets processed weird. In the hand above, his name ends up looking like this: Seat 6: Big C ($host in Chips) ($65.00 in Chips). It seems like the code can't handle a parenthesis in the name right now?

Let me know if that helps. I have attached my converted hand history and original hand history to help you debug.

Thank you so much for helping! poker_now_log_pgllZHs04W8FLhlwTAErBIuHw.csv

poker_now_log_pgllZHs04W8FLhlwTAErBIuHw-converted.txt

[evolutionsoftswiss]

Thanks for your Feedback, Andrew. I've published a new Release resolving this Issue.

As stated in the README.md the parantheses in player names are not supported out of the box. This limitation remains and you have to make entries in name-mappings.properties for your parantheses player names. To support the name "Big C (host)" you would have the following or similar in the name-mappings.properties: bigCHost=Big C (host)