ErrorHands : Likely missing "raise XX to YY"

[Deckhole]

poker_now_log_O-p_9z9-wxUnyMfTU-EaU0wYz.csv

This log created a lot of errors. Let me know if there is anything I could do to help.

[evolutionsoftswiss]

Thanks for the example file causing conversion errors. I'll have a look this week-end and will post updates here. You could of course also check out the project and try to find a correction for the problems with a local version.

[Deckhole]

I will check out the project as well and look to make corrections!

Thanks for all your effort. I started a converter using Wolfram Language (Mathematica) and then found yours.

My main problem is I don’t have access to PokerStar hands, so I don’t know their structure for certain situations like running it twice and having a straddle or a missed blind, etc.

On Sat, Oct 9, 2021 at 4:10 AM evolutionsoftswiss @.***> wrote:

Thanks for the example file causing conversion errors. I'll have a look this week-end and will post updates here. You could of course also check out the project and try to find a correction for the problems with a local version.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/evolutionsoftswiss/pokernow-handhistory-converter/issues/7#issuecomment-939253193, or unsubscribe https://github.com/notifications/unsubscribe-auth/AV7NSYLQ7R2CUU4FAQQGHPLUF72FFANCNFSM5FU5HY6A . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

[evolutionsoftswiss]

I suppose the errors were coming from the player name containing a point. The point is also used with indexOf() to get the hand time without milliseconds. Additionally also on showdowns the indexOf a point was used to get the conversed showdown action. From what I've seen with your provided file, a dealer with a point in the name or winning the showdown caused the conversion errors.

Replacing those indexOf statements by lastIndexOf should correct the Issues. The code will then still find the right contents instead of finding the point from the name.

Is the potential upcoming version attached correcting the problems for you ? handhistory-converter-0.2.2-SNAPSHOT-program.zip

[Deckhole]

Yeah, I was mistaken in my original comment, I thought the error file was post conversion effort.

I didn’t see that a player had a point in there name. Thanks so much for looking into this.

I may work on a “tournament converter” that you use when there was a tournament. Of course there would have to be a input file that contains the payouts so the results could be converted and added to the PS file. I am using HoldemManager as the hand reader database and analysis.

Trying to figure out how to get HoldemManager to know who the hero is in the PokerNow hands because the converter doesn’t show hole cards for hero.

Sent from my iPhone

On Oct 10, 2021, at 1:11 PM, evolutionsoftswiss @.***> wrote:

 I suppose the errors were coming from the player name containing a point. The point is also used with indexOf() to get the hand time without milliseconds. Additionally also on showdowns the indexOf a point was used to get the conversed showdown action. From what I've seen with your provided file, a dealer with a point in the name or winning the showdown caused the conversion errors.

Replacing those indexOf statements by lastIndexOf should correct the Issues. The code will then still find the right contents instead of finding the point from the name.

Is the potential upcoming version attached correcting the problems for you ? handhistory-converter-0.2.2-SNAPSHOT-program.zip

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.

[evolutionsoftswiss]

Okay, I'll create a better version with the correct handling of point in names soon.

For setting up to read your own hole cards please follow the description in the README.md. You have to configure both property files to make that work: https://github.com/evolutionsoftswiss/pokernow-handhistory-converter#readme

[Deckhole]

I thought I had done this, I’ll take a second look. Guess I messed something up.

Thanks again! My Java isn’t instinctual enough to rapidly follow the code. It will take me a while to get up to speed.

Mark

Sent from my iPhone

On Oct 10, 2021, at 3:16 PM, evolutionsoftswiss @.***> wrote:

 Okay, I'll create a better version with the correct handling of point in names soon.

For setting up to read your own hole cards please follow the description in the README.md. You have to configure both property files to make that work: https://github.com/evolutionsoftswiss/pokernow-handhistory-converter#readme

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.

[Deckhole]

For setting up for reading my hole cards (whether I show or not), I can't get it to work. I think I've tried every permutation. My PokerNow nickname is Deckhole, and it does substitute "Hero" for Deckhole... but no hole cards.

From "conversion.properties"

If you want to read your hole cards set to true, you have to give your

unique name according to

minimal name-mappings.properties

readYourHoleCards = true yourUniqueName = Hero

Which of the supported game types are converted, true ones get converted

false ones are skipped convertOmahaHiHands = true convertOmahaHiLoHands = true convertTexasHands = true

From "name-mappings.properties"

yourUniqueName needs to be given also in conversion.properties

Hero = Deckhole

buddyName1 = pokernowNickname1,pokernowNickname123

buddyName2 = pokernowNickname22,pokernowNickname44

On Sun, Oct 10, 2021 at 6:49 PM Mark Decker @.***> wrote:

I thought I had done this, I’ll take a second look. Guess I messed something up.

Thanks again! My Java isn’t instinctual enough to rapidly follow the code. It will take me a while to get up to speed.

Mark

Sent from my iPhone

On Oct 10, 2021, at 3:16 PM, evolutionsoftswiss @.***> wrote:



Okay, I'll create a better version with the correct handling of point in names soon.

For setting up to read your own hole cards please follow the description in the README.md. You have to configure both property files to make that work: https://github.com/evolutionsoftswiss/pokernow-handhistory-converter#readme

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/evolutionsoftswiss/pokernow-handhistory-converter/issues/7#issuecomment-939537268, or unsubscribe https://github.com/notifications/unsubscribe-auth/AV7NSYP2NWRBY7ULJAMNSXLUGHRADANCNFSM5FU5HY6A . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

[Deckhole]

I think I figured out what is going on.

When the converter exposes the "heros" hole cards, it does so by acting as though the player "shows" their cards at the end of the hand, rather than designating them as "Hole Cards". This is treated differently in programs like HoldemManager in two ways.

1) I believe Hold'em manager uses the hole card exposure to determine the "hero". WIthout it HoldemManger just assumes the Hero is another player and does combine it with other site hands.

2) In HoldemManager you can elect not to see opponents cards during replay, but you still can see your cards. However, when the hole cards aren't designated (merely exposed at end of hand) it won't show the hero's cards unless you choose to expose opponents cards as well.

Does this sound right to you? I am not see "Your Hole cards are [ X Y ]" in the conversion. However, it does show the Hero's cards exposed at the end of the hand with a "Hero shows [ X Y ]"

Thanks again, Mark

On Sat, Oct 9, 2021 at 4:10 AM evolutionsoftswiss @.***> wrote:

Thanks for the example file causing conversion errors. I'll have a look this week-end and will post updates here. You could of course also check out the project and try to find a correction for the problems with a local version.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/evolutionsoftswiss/pokernow-handhistory-converter/issues/7#issuecomment-939253193, or unsubscribe https://github.com/notifications/unsubscribe-auth/AV7NSYLQ7R2CUU4FAQQGHPLUF72FFANCNFSM5FU5HY6A . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

[Deckhole]

Your re-mapping of names (a very nice and slick feature, btw) fixes the issue by just mapping to a name without a “.” So I guess you replace the name before the major conversion takes place! Very nice.

Mark

Sent from my iPhone

On Oct 10, 2021, at 6:49 PM, Mark Decker @.***> wrote:

I thought I had done this, I’ll take a second look. Guess I messed something up.

Thanks again! My Java isn’t instinctual enough to rapidly follow the code. It will take me a while to get up to speed.

Mark

Sent from my iPhone

On Oct 10, 2021, at 3:16 PM, evolutionsoftswiss @.***> wrote:

 Okay, I'll create a better version with the correct handling of point in names soon.

For setting up to read your own hole cards please follow the description in the README.md. You have to configure both property files to make that work: https://github.com/evolutionsoftswiss/pokernow-handhistory-converter#readme

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.