Closed evomimic closed 1 month ago
@evomimic there is no way to set the key in the stage_new_holon dance and therefore unable to match on expected from responsebody.staging_area
how best to proceed for implementing set_key_manually in tests?
should we add an optional parameter: key in RequestBody::ParameterValues ?
When you create a holon in the dance_fixture, you can call the set_key_manually
method to set the key on the holon.
When shipping references to staged and saved holons back and forth between client and guest, we introduced a PortableReference data type. This enhancement makes some adjustments to StagedReference and SmartReference to allow HolonReference to be used as a portable reference type and eliminate the need for a separate PortableReference structure.
Currently SmartReference and StagedReference includes keys, but there doesn't seem to be a compelling reason for that. Their underlying holons provide access to their keys via
get_key
methods.This enhancement drops key fields from both.Proposal
key
field andrc_holon
fields from the definition of SmartReferencerc_holon
from a SmartReference are delegated toget_rc_holon
calls on the cache. Theensure_rc_holon
function can be dropped. Calls an ensure_rc_holon should be replaced with calls on the cache_manager'sget_rc_holon
-- as should any attempts to access the SmartReference's (now-deleted)rc_holon
field directly.key
field from the definition of StagedReferenceTesting
Ensure no loss of existing functionality by running regression tests:
Definition of Done