evomimic / map-holons

3 stars 1 forks source link

Unify PortableReference into HolonReference #89

Closed evomimic closed 1 month ago

evomimic commented 1 month ago

When shipping references to staged and saved holons back and forth between client and guest, we introduced a PortableReference data type. This enhancement makes some adjustments to StagedReference and SmartReference to allow HolonReference to be used as a portable reference type and eliminate the need for a separate PortableReference structure.

Currently SmartReference and StagedReference includes keys, but there doesn't seem to be a compelling reason for that. Their underlying holons provide access to their keys viaget_key methods.This enhancement drops key fields from both.

Proposal

Testing

Ensure no loss of existing functionality by running regression tests:

Definition of Done

dauphin3 commented 1 month ago

@evomimic there is no way to set the key in the stage_new_holon dance and therefore unable to match on expected from responsebody.staging_area

how best to proceed for implementing set_key_manually in tests?

should we add an optional parameter: key in RequestBody::ParameterValues ?

evomimic commented 1 month ago

When you create a holon in the dance_fixture, you can call the set_key_manually method to set the key on the holon.