Closed nphias closed 4 months ago
It's great to see the client-side tests starting to take shape!
I was able to checkout and run this branch and all tests passed. Cool!
I've been reviewing the code and it looks pretty straightforward. It did bring to light some things I want to talk with you about. Let's do a walk-through at our meeting on Tuesday. Here's a brief list of topics I've identified so far:
with_properties
dance supports multiple properties in a single call, add_property
only supports a single property. The questions raised in this PR will be resolved in Issue #96. Approving the PR for merge.
ready to merge