evonove / django-money-rates

Currency conversion for django money
BSD 3-Clause "New" or "Revised" License
90 stars 61 forks source link

Add Django migrations, fix dependencies, add support for Django 1.9+ #24

Open benjaoming opened 6 years ago

benjaoming commented 6 years ago

Taking over from #23

Remove support for versions prior to 1.9

This is a take it or leave it PR, I'm not going to do any further work beyond "works for me" :)

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.2%) to 87.912% when pulling 9668ca5f6099d105fe155e08cf009ad6adaf3ff8 on benjaoming:bug/django-19 into ac1f7636b9a38d3e153eb833019342c4d88634c2 on evonove:master.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.2%) to 87.912% when pulling 56215527eb326e6b2481a22d0fce343852548ebf on benjaoming:bug/django-19 into ac1f7636b9a38d3e153eb833019342c4d88634c2 on evonove:master.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.2%) to 87.912% when pulling 28e85d03b51b87332eb8ae26f42c3aca5e837740 on benjaoming:bug/django-19 into ac1f7636b9a38d3e153eb833019342c4d88634c2 on evonove:master.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.2%) to 87.912% when pulling 28e85d03b51b87332eb8ae26f42c3aca5e837740 on benjaoming:bug/django-19 into ac1f7636b9a38d3e153eb833019342c4d88634c2 on evonove:master.

afeef commented 6 years ago

This works for me too. Any plans to merge this and update the package on PyPI?

benjaoming commented 6 years ago

@afeef there is work to implement a new django-money-rates in https://github.com/django-money/django-money/pull/385

The work is already so far that I wouldn't bother forking this project :) I think @Stranger6667 had a party designing and implementing djmoney.contrib.exchange, it already looks really good :)