search

evonzee / grayles-modpack-updater

0 stars 0 forks source link

Bad asset pool 'pengrandomspear' #10

Closed evonzee closed 4 years ago

evonzee commented 4 years ago

[Error] Could not instantiate item '[pengrandomspear, 1, {}]'. (LuaException) Error code 2, [string "/scripts/util.lua"]:580: bad argument #1 to 'pairs' (table expected, got nil) stack traceback: [C]: in ? [C]: in function '_ENV.pairs' [string "/scripts/util.lua"]:580: in field 'mergeTable'

evonzee commented 4 years ago

This looks like it is happening because pengrandomspear has a chance to include the elementalAura and elementalPillar abilities even though it may not be an elemental weapon ("physical" elemental type). These abilities require an elemental damage type to be present on the weapon since they have no configuration for "physical".

I can fix this by dropping physical as a damage type option, dropping those abilities from the pool, or patching support for physical damage (nonsensical though it may be) into those abilities. Preference?

evonzee commented 4 years ago

Umbra's choice is teh physical aura and pillar. Patched, let's see how it works.

Umbralink commented 4 years ago

It only a fix for now until the author decide to fix it himself, we may do as we wish. :)