Fix overriding global method for all `:sql-jdbc` drivers

evosec / metabase-firebird-driver

A plugin that allows Metabase to connect to FirebirdSQL databases.

https://github.com/metabase/metabase/

MIT License

28 stars 7 forks source link

Fix overriding global method for all `:sql-jdbc` drivers #18

Closed camsaul closed 11 months ago

camsaul commented 11 months ago

The :firebird driver implements sql-jdbc.sync/have-select-privilege? for :sql-jdbc rather than :firebird which ultimately breaks the method for other drivers like Postgres, for example

https://github.com/metabase/metabase/issues/32124

Nikos410 commented 11 months ago

Whoops, missed that in #15. Thanks for the heads-up and for the fix @camsaul :)