search

evosec / metabase-firebird-driver

A plugin that allows Metabase to connect to FirebirdSQL databases.
https://github.com/metabase/metabase/
MIT License
28 stars 7 forks source link

Driver stopped working in 0.32.10 #2

Closed kumajaya closed 4 years ago

kumajaya commented 4 years ago

Please do an update related to https://github.com/metabase/metabase/commit/e7100252205e01c16daa431f52539dbf8d26c438#diff-d77ef6d7d60b04c2447263a86bfaeabf

Thanks in advance.

Nikos410 commented 4 years ago

Thanks for the info! Is there documentation somewhere on how exactly the date functions have to look now?

kumajaya commented 4 years ago

I'm not sure about it. I only needs a quick fix for my production machine, so I use H2 diver as a reference. I changed line 166 to:

(defmethod driver/date-add :firebird [driver dt amount unit] (if (= unit :quarter) (recur driver dt (hx/* amount 3) :month) (hsql/call :dateadd (hsql/raw (name unit)) amount (hx/cast :timestamp (hx/literal :now)))))

Nikos410 commented 4 years ago

Thanks! I will look into it when I'm back at the office.

Nikos410 commented 4 years ago

Please try the latest release, the driver should be working with the current version of Metabase.