search

evosec / metabase-firebird-driver

A plugin that allows Metabase to connect to FirebirdSQL databases.
https://github.com/metabase/metabase/
MIT License
28 stars 7 forks source link

Feature/metabase 48 #21

Open Nikos410 opened 5 months ago

mat02 commented 4 months ago

Thank you for your hard work 👏 It looks like change to HSQL 2 brought some more breaking changes, i.e. :modifiers not longer exists: https://github.com/seancorfield/honeysql/blob/7a7a01eeaaa56b6e00574feb63be9c09e782f2c2/doc/differences-from-1-x.md?plain=1#L166

This breaks FIRST and SKIP implementation in apply-top-level-clause: https://github.com/evosec/metabase-firebird-driver/blob/a240bf29229f2ad7e6467c275680000ba06dd509/src/metabase/driver/firebird.clj#L83 https://github.com/evosec/metabase-firebird-driver/blob/a240bf29229f2ad7e6467c275680000ba06dd509/src/metabase/driver/firebird.clj#L87

Could you please look into possible workaround?

Nikos410 commented 4 months ago

Hey @mat02

thanks for that link!

That changes were not mentioned in die Metabase Upgrade docs, so I missed them - I will look into that!

Still, I find it weird that the driver is working fine for us and only some people are experiencing problems...

Best Nikos -------- Original-Nachricht -------- Am 7. März 2024, 11:25, schrieb Mateusz Knapik :

Thank you for your hard work 👏 It looks like change to HSQL 2 brought some more breaking changes, i.e. :modifiers not longer exists: https://github.com/seancorfield/honeysql/blob/7a7a01eeaaa56b6e00574feb63be9c09e782f2c2/doc/differences-from-1-x.md?plain=1#L166

This breaks FIRST and SKIP implementation in apply-top-level-clause: https://github.com/evosec/metabase-firebird-driver/blob/a240bf29229f2ad7e6467c275680000ba06dd509/src/metabase/driver/firebird.clj#L83 https://github.com/evosec/metabase-firebird-driver/blob/a240bf29229f2ad7e6467c275680000ba06dd509/src/metabase/driver/firebird.clj#L86

Could you please look into possible workaround?

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: @.***>

mat02 commented 4 months ago

Maybe this is related to the FB version. We run 3.0 in SuperServer mode (I believe this is the same as you are, at least I think I saw it mentioned somewhere), but only stumbled on this problem with :modifiers keyword in in some specific questions, where Metabase automatically applies top-level clause to limit number of rows (not exactly sure why.

Unfortunately, I am not familiar with Clojure (nor other functional languages) enough to fix this myself :/