evothings / evothings-studio

Evothings Studio
http://www.evothings.com/
Apache License 2.0
53 stars 33 forks source link

Use of xdg-open on Linux #109

Open ghost opened 8 years ago

ghost commented 8 years ago

Report from user:

"I did not like the use of xdg­open in the application. It caused my computer to hang because of some wrong settings in the OS (inode/directory set to a non­GUI app). While I do understand that this is a matter of incorrectly configured OS, using it might still be quite risky."

Info on xdg-open: https://wiki.archlinux.org/index.php/Xdg-open

fredrikeldh commented 8 years ago

I'm confused; where do we use xdg-open? I can't find any mention of it in the code.

fredrikeldh commented 8 years ago

Found it: Shell.openExternal(). node-webkit calls xdg-open from that function. We call Shell.openExternal() in hyper-ui.js.

Google seems divided on whether or not one should use xdg-open.