evothings / evothings-studio

Evothings Studio
http://www.evothings.com/
Apache License 2.0
53 stars 33 forks source link

Test that Evothings Studio 2.0 works with custom Cordova projects #138

Closed ghost closed 8 years ago

ghost commented 8 years ago

Problems have been reported when using Evothings Studio 2.0 with a custom Cordova app (cordova.js not found). Investigate this. Also update documentation for how to connect from a custom Cordova app to Evothings Workbench.

ghost commented 8 years ago

Possibly related issue: https://github.com/evothings/evothings-studio/issues/90

ghost commented 8 years ago

Done testing and status is that connecting from a custom Cordova app currently does not work.

Problems:

Current code that does not work:

var androidCordovaAppPath =
    mBasePath +
    '../platforms/android/assets/' +
    'www' + path

This works (hard-coded platform to 'android' when testing):

var androidCordovaAppPath =
    mBasePath +
    '/../platforms/android/assets/' +
    'www' + path

Better solution, not tested though (note that the "missing slash" is not needed when using join):

var androidCordovaAppPath =
    PATH.normalize(
        PATH.join(
            mBasePath,
            '../platforms/android/assets/',
            'www',
            path))

Conclusion is that this problem can be fixed, but the server needs to be updated to send the correct platform given in the HTTP request.

If it is desirable to keep this functionality is another question, see discussion in this issue: https://github.com/evothings/evothings-doc/issues/91

gokr commented 8 years ago

Let's decide this one during Fredrika, I agree with the idea to skip this functionality and instead focus on making it easy to build Viewers. Thus recommend to close.

ghost commented 8 years ago

Closing issue, supported method for adding custom plugins is to build Evothings Viewer.