authentication to github should take place in the browser not the app itself

evothings / evothings-studio

Evothings Studio

http://www.evothings.com/

Apache License 2.0

53 stars 33 forks source link

authentication to github should take place in the browser not the app itself #152

Closed mogorman closed 8 years ago

mogorman commented 8 years ago

The current version of the app has the user sign in to github inside of the app to add the oauth token. this is insecure as there is no way of knowing that this is a real github page, it also defeats purpose of oauth token in first place. Could be fixed by popping it out to users web browser.

gokr commented 8 years ago

This is fixed in 2.1, done in the regular browser instead. This is the Personalize button now.