search

evothings / evothings-studio

Evothings Studio
http://www.evothings.com/
Apache License 2.0
53 stars 33 forks source link

Change ugly hack to make _filesync work with es6 builds #173

Open psvensson opened 8 years ago

psvensson commented 8 years ago

Due to reasons, it was nontrivial to just detect file changes in a _filescyn directory anywhere in an es6 project, since basedir got magically remapped to basedir+wwwPath between detection and injection. A quick fix was inflicted on the studio to see if the path ended in /www and then instead check in foo.replace('www','app'). That's no way to behave at a rock'n'roll concert, but time was short.

Revisit this and give it some more love, possible in combination with moving to a proper app registry instead of setting lots of globals when apps change. Plz.

perttikasanenhitseed commented 8 years ago

If could have the foo.replace('www','app') to use, instead of the fixed directory name 'app', the value of "app-dir" from evothings.json...

...I would not noticed there is anything suspicious going on

psvensson commented 8 years ago

Yes, absolutely. This is the way we are thinking as well.