search

evrardjp / ansible-keepalived

Keepalived role for ansible deployment
Apache License 2.0
98 stars 98 forks source link

Commenting out unused variables for shellcheck compliance. #256

Closed crazzy closed 1 year ago

crazzy commented 1 year ago

Found this role being used in a project I'm collaborating on, where I want to run shellcheck on every single shellscript, so figured I'd patch this one and submit a PR.

evrardjp commented 1 year ago

Sorry for the late answer.

You can see the merge wasn't done due to failure in CI.

Here is the PR of the CI change. https://github.com/evrardjp/ansible-keepalived/pull/259 .

When this is merged, I will rebase your code and run it again. If all goes well, it will be merged this week.

evrardjp commented 1 year ago

I just noticed that shellcheck isn't included in the tests, would you be okay to add it? Probably need to add somethign on the runners (.github/workflow/) and in the tox.ini (the shellcheck invocation).

Edit: We can do so in a follow up PR.