search

evrencoskun / TableView

TableView is a powerful Android library for displaying complex data structures and rendering tabular data composed of rows, columns and cells.
MIT License
3.14k stars 459 forks source link

Fix single click on cells #181

Open damianogiusti opened 5 years ago

damianogiusti commented 5 years ago

This PR fixes an issue which caused the single click listener not to being triggered. The problem appears when clicking onto a cell (no matter if header or not).

It can be reproduced by launching the example project and single-clicking onto a cell: a Toast will appear incorrectly indicating that a long click has been performed.

The checks using mGestureDetector.onTouchEvent(e) aren't necessary into AbstractItemClickListener subclasses because the methods in which are used are called during a mGestureDetector.onTouchEvent(e) invocation, started from the onInterceptTouchEvent method of the AbstractItemClickListener.

MGaetan89 commented 3 years ago

Is this fix still necessary with the latest version of the library? I think some changes were made regarding this issue.