search

evrencoskun / TableView

TableView is a powerful Android library for displaying complex data structures and rendering tabular data composed of rows, columns and cells.
MIT License
3.14k stars 459 forks source link

Tableview Example App Data Model inconsistency #303

Closed Zardozz closed 4 years ago

Zardozz commented 4 years ago

In https://github.com/evrencoskun/TableView/blob/master/app/src/main/java/com/evrencoskun/tableviewsample/tableview/model/Cell.java

The constructor takes an Object type for it's constructor for the data variable but the setData method only takes a String type Object to update the data in this Data Model.

This has no affect on the Example App, but as an example of a Data Model implementation it is not consistent.

Suggest that the setData method be changed to:-

public void setData(@Nullable Object data) {
        mData = data;
    }

(Sorry this is not worth doing a PR for a one word change)

evrencoskun commented 4 years ago

Thanks, @Zardozz, it seems to be overlooked.