More License inconsistencies

[Zardozz]

The License file https://github.com/evrencoskun/TableView/blob/master/LICENSE and now the artifact are licensed with the MIT License

BUT some (a lot) of the source files like https://github.com/evrencoskun/TableView/blob/master/tableview/src/main/java/com/evrencoskun/tableview/TableView.java

have a copyright header of

/*

• Copyright (c) 2018. Evren Coşkun
• Licensed under the Apache License, Version 2.0 (the "License");
• you may not use this file except in compliance with the License.
• You may obtain a copy of the License at
• http://www.apache.org/licenses/LICENSE-2.0
• Unless required by applicable law or agreed to in writing, software
• distributed under the License is distributed on an "AS IS" BASIS,
• WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
• See the License for the specific language governing permissions and
• limitations under the License.

• */

Which is for Apache 2.0 License

I suggest aligning the copyright headers with the main License file. (If that is the correct license you want to use)

I suggest that you look at your editors copyright auto header generator and change that to the correct License

If a lot of the source files need changing is probably a background task to do when another change are made.

[MGaetan89]

@evrencoskun what's your take on this (MIT vs. Apache)? I can submit a PR based on your choice to unify this if you want.

Initial report in #310.

[evrencoskun]

@MGaetan89 MIT would be fine for me.

@Zardozz @MGaetan89 Thanks, guys!

[Zardozz]

There is very little difference, personally as an open source developer I prefer MIT as it requires a more prominent credit given to the project than Apache does for Apps that use it and is slightly less onerous on forked projects.

[Zardozz]

If might also be worth adding a CONTRIBUTING.md that covers the chosen license

Something like if MIT is chosen :-

By making a contribution to this project you are agreeing to have your contributions governed by the MIT License copyright statement. This means that to the extent possible under law, you transfer all copyright and related or neighbouring rights of the code or documents you contribute to the project itself. You also represent that you have the authority to perform the above waiver with respect to the entirety of you contributions.

The CONTRIBUTING.md could also cover other requirements to help make a successful submission e.g.

Ideally contributions should be backward compatible and not break existing users of the Library. Ideally the new library code should have automated tests to cover new or changed functionality. Library code should pass all exiting automated tests. Library code should be manually checked against the Sample App and TableViewSample 2 App Library code should be tested where possible against a range of Android versions starting with the minimum supported API version (currently API 14) to the highest current release production API version. Suggested documentation wiki updates should be provided with a contribution.

[evrencoskun]

@Zardozz make sense! 👍

[MGaetan89]

@Zardozz this has been fixed and released. Can this issue and #310 be closed?

[Zardozz]

Yes can be closed and I've closed #310 as well