search

evristzam / ndt

Automatically exported from code.google.com/p/ndt
Other
0 stars 0 forks source link

Issue related to running web100clt with the --web100variables option #100

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Steps to reproduce:
1. Run NDT client with the --web100variables option

Expected results:

All web100 variables are printed properly.

Actual results:

There is an invalid header at the beginning:

 --- Detailed description of the (null) variables ---

Original issue reported on code.google.com by jslawin...@soldevelo.com on 22 Nov 2013 at 10:02

GoogleCodeExporter commented 9 years ago 
For now, header using "ServerType" variable in this header (which is null). 
ServerType is known after connection to server and check version comparision at 
line: 
https://code.google.com/p/ndt/source/browse/trunk/src/web100clt.c#770
Should we make connection just for this header to know ServerType?

All web100 variables are printed from a pre-defined array in varinfo.h.

Original comment by smale...@soldevelo.com on 14 Feb 2014 at 1:01

GoogleCodeExporter commented 9 years ago 
After awhile, I think that the best way will be just remove variable:
printf(" --- Detailed description of the %s variables ---\n\n", ServerType);
to
printf(" --- Detailed description of the Web100/Web10g variables ---\n\n");

It's no matter what server it is. It always write the same variables. Are you 
agree?

Original comment by smale...@soldevelo.com on 14 Mar 2014 at 3:47

GoogleCodeExporter commented 9 years ago 
Yes, you are right. However, we should also rename --web100variables to 
--webvariables and fix the usage screen.

Original comment by jslawin...@soldevelo.com on 19 Mar 2014 at 10:53

GoogleCodeExporter commented 9 years ago 
Changes available on Issue100 branch. Feel free to review (r1033).

Original comment by smale...@soldevelo.com on 21 Mar 2014 at 11:28

GoogleCodeExporter commented 9 years ago 
LGTM

Original comment by jslawin...@soldevelo.com on 24 Mar 2014 at 10:11

GoogleCodeExporter commented 9 years ago

Original comment by smale...@soldevelo.com on 25 Mar 2014 at 9:37

GoogleCodeExporter commented 9 years ago

Original comment by skost...@soldevelo.com on 23 Jun 2014 at 5:38