search

evristzam / ndt

Automatically exported from code.google.com/p/ndt
Other
0 stars 0 forks source link

The Java client does not handle the wait flag "9977 - Server Fault". #102

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
According to the wiki 
(https://code.google.com/p/ndt/wiki/NDTProtocol#Queuing_clients), one of the 
possible SRV_QUEUE messages sent by the server to the client is "9977 - Server 
Fault".

The c client supports it. See 
https://code.google.com/p/ndt/source/browse/trunk/src/web100clt.c#695.

Is there a reason why the Java client does not support it?

That check would probably be before line 
https://code.google.com/p/ndt/source/browse/trunk/Applet/Tcpbw100.java#2443.

Original issue reported on code.google.com by tizi...@google.com on 22 Nov 2013 at 3:34

GoogleCodeExporter commented 9 years ago 
The behaviour should be consistent in both Java and C client. However, this is 
a bigger issue than only missing 9977 support on the Java side. For example 
both clients support 9999 (which is not described on the wiki), but the current 
NDT server version is not sending 9977 nor 9999 in any case. Moreover, server 
is sending 9988 from several different places, but it should send 9977 from at 
least some of them.

Original comment by jslawin...@soldevelo.com on 22 Nov 2013 at 4:18

GoogleCodeExporter commented 9 years ago 
Got it. That is indeed a bigger problem. Thanks for the clarification!

I have another related question. :)
AFAIU from the code, the Java client fails the test if it receives 
SRV_QUEUE_SERVER_BUSY -- 
https://code.google.com/p/ndt/source/browse/trunk/Applet/Tcpbw100.java#2448
SRV_QUEUE_SERVER_BUSY_60s -- 
https://code.google.com/p/ndt/source/browse/trunk/Applet/Tcpbw100.java#2459

Am I reading the code correctly?
If so, is this the expected behavior?

Thanks again!

Original comment by tizi...@google.com on 22 Nov 2013 at 4:52

GoogleCodeExporter commented 9 years ago 
Yes, you got it correctly. SRV_QUEUE_SERVER_BUSY means that the server is too 
busy at the moment and according to the documentation 
(https://code.google.com/p/ndt/wiki/NDTProtocol#Queuing_clients) the connection 
should be dropped.

I do not see SRV_QUEUE_SERVER_BUSY_60s in the documentation nor the server code.

Original comment by jslawin...@soldevelo.com on 25 Nov 2013 at 2:00

GoogleCodeExporter commented 9 years ago

Original comment by jslawin...@soldevelo.com on 28 Nov 2013 at 8:59

GoogleCodeExporter commented 9 years ago

Original comment by smale...@soldevelo.com on 10 Feb 2014 at 12:19

GoogleCodeExporter commented 9 years ago 
Changes available on branch applet_102. Feel free to review.

Original comment by smale...@soldevelo.com on 13 Feb 2014 at 8:46

GoogleCodeExporter commented 9 years ago

Original comment by smale...@soldevelo.com on 4 Mar 2014 at 8:50

GoogleCodeExporter commented 9 years ago

Original comment by skost...@soldevelo.com on 23 Jun 2014 at 5:48