search

evristzam / ndt

Automatically exported from code.google.com/p/ndt
Other
0 stars 0 forks source link

Java client does not check the version compatibility #104

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
According to the documentation 
(https://code.google.com/p/ndt/wiki/NDTProtocol#Verifying_version_compatibility)
, the NDT client should check the compatibility of its version with the server 
version.

The c client does the check 
https://code.google.com/p/ndt/source/browse/trunk/src/web100clt.c#769.
while the Java client does not (besides checking that the version starts with 
'v'):
https://code.google.com/p/ndt/source/browse/trunk/Applet/Tcpbw100.java#2520.

Are the c and Java clients supposed to have the same behavior or is the 
difference intentional (possibly because of backward compatibility)?

Thanks!

Original issue reported on code.google.com by tizi...@google.com on 22 Nov 2013 at 5:36

GoogleCodeExporter commented 9 years ago 
The Java client used a different version numbering in the past, so maybe this 
is the reason why this check was not implemented earlier. However, now both c 
and Java applications are using the same version numbering, so we should be 
able to implement this check.

Original comment by jslawin...@soldevelo.com on 25 Nov 2013 at 2:30

GoogleCodeExporter commented 9 years ago 
I'd concur on implementing the check, especially given that the applet and 
server tend to be installed as one unit.

Original comment by AaronMat...@gmail.com on 26 Nov 2013 at 12:59

GoogleCodeExporter commented 9 years ago

Original comment by jslawin...@soldevelo.com on 28 Nov 2013 at 9:00

GoogleCodeExporter commented 9 years ago

Original comment by smale...@soldevelo.com on 5 Feb 2014 at 2:57

GoogleCodeExporter commented 9 years ago 
Fixed issue with Java client does not check the version compatibility. Changes 
are available on applet_104 branch. Feel free to review it.

Original comment by smale...@soldevelo.com on 7 Feb 2014 at 8:21

GoogleCodeExporter commented 9 years ago 
Looks fine to me. Commit at will.

Original comment by AaronMat...@gmail.com on 7 Feb 2014 at 1:48

GoogleCodeExporter commented 9 years ago 
Like with the C client it should be matching "Web100" not "web100".

Other than that looks good and seems to be work well.

Original comment by rsanger...@gmail.com on 8 Feb 2014 at 2:54

GoogleCodeExporter commented 9 years ago 
Thanks for review. I've already correct a typo.

Original comment by smale...@soldevelo.com on 10 Feb 2014 at 8:30

GoogleCodeExporter commented 9 years ago 
Cool, looks good merge it into trunk.

Original comment by rsanger...@gmail.com on 10 Feb 2014 at 9:58

GoogleCodeExporter commented 9 years ago

Original comment by smale...@soldevelo.com on 10 Feb 2014 at 12:15

GoogleCodeExporter commented 9 years ago

Original comment by skost...@soldevelo.com on 23 Jun 2014 at 5:53