search

evristzam / ndt

Automatically exported from code.google.com/p/ndt
Other
0 stars 0 forks source link

Wrong error messages in S2C tests of Java client. #105

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Hi!

Two error messages printed during the s2c test in the Java client don't seem to 
be correct, as they are different from the error messages raised in any other 
part of the code in similar situations.

In particular, it seems to me that:

1) https://code.google.com/p/ndt/source/browse/trunk/Applet/Tcpbw100.java#1979
should use "protocolError" instead of "unknownServer" (similarly to 
https://code.google.com/p/ndt/source/browse/trunk/Applet/Tcpbw100.java#1935)

2) https://code.google.com/p/ndt/source/browse/trunk/Applet/Tcpbw100.java#1987
should use "inboundWrongMessage" instead of "serverFail" (similarly to 
https://code.google.com/p/ndt/source/browse/trunk/Applet/Tcpbw100.java#1942)

Is my guess correct or am I missing something?

Thanks!

Original issue reported on code.google.com by tizi...@google.com on 27 Nov 2013 at 3:31

GoogleCodeExporter commented 9 years ago

Original comment by jslawin...@soldevelo.com on 28 Nov 2013 at 9:00

GoogleCodeExporter commented 9 years ago 
Yes, I agree with you. These error messages are invalid and should be changed.

Original comment by jslawin...@soldevelo.com on 28 Nov 2013 at 9:44

GoogleCodeExporter commented 9 years ago

Original comment by smale...@soldevelo.com on 4 Feb 2014 at 11:06

GoogleCodeExporter commented 9 years ago

Original comment by smale...@soldevelo.com on 5 Feb 2014 at 11:36

GoogleCodeExporter commented 9 years ago 
Fixed issue with wrong error messages in S2C tests of Java client. Changes are 
available on applet_105 branch.

Original comment by smale...@soldevelo.com on 5 Feb 2014 at 11:40

GoogleCodeExporter commented 9 years ago 
Seems fine to me. Feel free to merge to trunk.

Original comment by AaronMat...@gmail.com on 5 Feb 2014 at 1:29

GoogleCodeExporter commented 9 years ago

Original comment by smale...@soldevelo.com on 6 Feb 2014 at 1:38

GoogleCodeExporter commented 9 years ago

Original comment by skost...@soldevelo.com on 23 Jun 2014 at 5:55