search

evristzam / ndt

Automatically exported from code.google.com/p/ndt
Other
0 stars 0 forks source link

Dead code in child_sig #121

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
There appears to be some dead code in child_sig that I think, if removed, will 
make the function more readable. An invocation of splint confirmed that my eyes 
were not deceiving me and that the code I spotted was really unreachable. 

Review request forthcoming.

Will

Original issue reported on code.google.com by hawki...@measurementlab.net on 10 Feb 2014 at 10:35

GoogleCodeExporter commented 9 years ago 
Seems reasonable to me

Original comment by AaronMat...@gmail.com on 11 Feb 2014 at 6:34

GoogleCodeExporter commented 9 years ago 
Thanks for the quick review! I actually hadn't anticipated your eagerness -- I 
posted here basically temporarily until we ran some tests with the code on some 
of the M-Lab test hosts. 

I will report back once those tests look normal. Thanks again!

Original comment by hawki...@measurementlab.net on 11 Feb 2014 at 6:37

GoogleCodeExporter commented 9 years ago 
I've been running this on an M-Lab test node, and it seems okay. I will merge 
if that's okay with everyone?

Original comment by hawki...@measurementlab.net on 14 Feb 2014 at 3:30

GoogleCodeExporter commented 9 years ago 
Fine by me

Original comment by AaronMat...@gmail.com on 14 Feb 2014 at 4:27

GoogleCodeExporter commented 9 years ago 
Thanks! Done!

Original comment by hawki...@measurementlab.net on 14 Feb 2014 at 4:47

GoogleCodeExporter commented 9 years ago

Original comment by hawki...@measurementlab.net on 14 Feb 2014 at 4:49

GoogleCodeExporter commented 9 years ago

Original comment by skost...@soldevelo.com on 23 Jun 2014 at 5:52